• Liu Bo's avatar
    Btrfs: fix BUG_ON in btrfs_mark_buffer_dirty · ef85b25e
    Liu Bo authored
    This can only happen with CONFIG_BTRFS_FS_CHECK_INTEGRITY=y.
    
    Commit 1ba98d08 ("Btrfs: detect corruption when non-root leaf has zero item")
    assumes that a leaf is its root when leaf->bytenr == btrfs_root_bytenr(root),
    however, we should not use btrfs_root_bytenr(root) since it's mainly got
    updated during committing transaction.  So the check can fail when doing
    COW on this leaf while it is a root.
    
    This changes to use "if (leaf == btrfs_root_node(root))" instead, just like
    how we check whether leaf is a root in __btrfs_cow_block().
    
    Fixes: 1ba98d08 (Btrfs: detect corruption when non-root leaf has zero item)
    Cc: stable@vger.kernel.org  # 4.8+
    Reported-by: default avatarJeff Mahoney <jeffm@suse.com>
    Signed-off-by: default avatarLiu Bo <bo.li.liu@oracle.com>
    Reviewed-by: default avatarFilipe Manana <fdmanana@suse.com>
    ef85b25e
disk-io.c 127 KB