• Larry Finger's avatar
    staging: rtl8723bs: Fix indenting errors and an off-by-one mistake in core/rtw_mlme_ext.c · ef9209b6
    Larry Finger authored
    Smatch lists the following:
    
      CHECK   drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
    drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:525 _mgt_dispatcher() warn: inconsistent indenting
    drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:1595 OnAssocReq() error: buffer overflow 'pstapriv->sta_aid' 32 <= 32
    drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:2391 dump_mgntframe_and_wait() warn: inconsistent indenting
    drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:2420 dump_mgntframe_and_wait_ack() warn: inconsistent indenting
    drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:4969 process_80211d() error: testing array offset 'i' after use.
    drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:5738 linked_status_chk() warn: inconsistent indenting
    drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:6459 sitesurvey_cmd_hdl() warn: inconsistent indenting
    
    The indenting problems were fixed with white-space changes. The error at
    line 1595 was the result of an off-by-one error in a for loop. The error
    at line 4969 was not fixed as that code lies inside a block of code that
    only is needed for 5G channels. This chip only works at 2.4 GHz.
    Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    ef9209b6
rtw_mlme_ext.c 203 KB