• Jerome Brunet's avatar
    net: phy: meson-gxl: detect LPA corruption · f1e2400a
    Jerome Brunet authored
    The purpose of this change is to fix the incorrect detection of the link
    partner (LP) advertised capabilities which sometimes happens with this PHY
    (roughly 1 time in a dozen)
    
    This issue may cause the link to be negotiated at 10Mbps/Full or
    10Mbps/Half when 100MBps/Full is actually possible. In some case, the link
    is even completely broken and no communication is possible.
    
    To detect the corruption, we must look for a magic undocumented bit in the
    WOL bank (hint given by the SoC vendor kernel) but this is not enough to
    cover all cases. We also have to look at the LPA ack. If the LP supports
    Aneg but did not ack our base code when aneg is completed, we assume
    something went wrong.
    
    The detection of a corrupted LPA triggers a restart of the aneg process.
    This solves the problem but may take up to 6 retries to complete.
    
    Fixes: 7334b3e4 ("net: phy: Add Meson GXL Internal PHY driver")
    Signed-off-by: default avatarJerome Brunet <jbrunet@baylibre.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    f1e2400a
meson-gxl.c 4.44 KB