• Gavin Shan's avatar
    powerpc/eeh: Fix partial hotplug criterion · f6bf0fa1
    Gavin Shan authored
    During error recovery, the device could be removed as part of the
    partial hotplug. The criterion used to come with partial hotplug
    is: if the device driver provides error_detected(), slot_reset()
    and resume() callbacks, it's immune from hotplug. Otherwise,
    it's going to experience partial hotplug during EEH recovery. But
    the criterion isn't correct enough: mlx4_core driver for Mellanox
    adapters provides error_detected(), slot_reset() callbacks, but
    resume() isn't there. Those Mellanox adapters won't be to involved
    in the partial hotplug.
    
    This fixes the criterion to a practical one: adpater with driver
    that provides error_detected(), slot_reset() will be immune from
    partial hotplug. resume() isn't mandatory.
    
    Fixes: f2da4ccf ("powerpc/eeh: More relaxed hotplug criterion")
    Cc: stable@vger.kernel.org #v4.4+
    Signed-off-by: default avatarGavin Shan <gwshan@linux.vnet.ibm.com>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    f6bf0fa1
eeh_driver.c 24.3 KB