• Arnaud Lacombe's avatar
    kconfig/nconf: prevent segfault on empty menu · f98ee769
    Arnaud Lacombe authored
    nconf does not check the validity of the current menu when help is
    requested (with either <F2>, '?' or 'h'). This leads to a NULL pointer
    dereference when an empty menu is encountered.
    
    The following reduced testcase exposes the problem:
    
    config DEP
            bool
    
    menu "FOO"
    
    config BAR
            bool "BAR"
            depends on DEP
    
    endmenu
    
    Issue will happen when entering menu "FOO" and requesting help.
    
    nconf is the only front-end which do not filter the validity of the
    current menu. Such filter can not really happen beforehand as other key
    which does not deals with the current menu might be entered by the user,
    so just bails out earlier if we encounter an invalid menu.
    
    Cc: Nir Tzachar <nir.tzachar@gmail.com>
    Cc: Andrej Gelenberg <andrej.gelenberg@udo.edu>
    Reported-by: default avatarAndrej Gelenberg <andrej.gelenberg@udo.edu>
    Signed-off-by: default avatarArnaud Lacombe <lacombar@gmail.com>
    Signed-off-by: default avatarMichal Marek <mmarek@suse.cz>
    f98ee769
nconf.c 38.4 KB