• Denys Vlasenko's avatar
    x86/asm/entry: Clear EXTRA_REGS for all executable formats · fc3e958a
    Denys Vlasenko authored
    On failure, sys_execve() does not clobber EXTRA_REGS, so we can
    just return to userpsace without saving/restoring them.
    
    On success, ELF_PLAT_INIT() in sys_execve() clears all these
    registers.
    
    On other executable formats:
    
      - binfmt_flat.c has similar FLAT_PLAT_INIT, but x86 (and everyone
        else except sh) doesn't define it.
    
      - binfmt_elf_fdpic.c has ELF_FDPIC_PLAT_INIT, but x86 (and most
        others) doesn't define it.
    
      - There are no such hooks in binfmt_aout.c et al. We inherit
        EXTRA_REGS from the prior executable.
    
    This inconsistency was not intended.
    
    This change removes SAVE/RESTORE_EXTRA_REGS in stub_execve,
    removes register clearing in ELF_PLAT_INIT(),
    and instead simply clears them on success in stub_execve.
    
    Run-tested.
    Signed-off-by: default avatarDenys Vlasenko <dvlasenk@redhat.com>
    Cc: Alexei Starovoitov <ast@plumgrid.com>
    Cc: Andy Lutomirski <luto@amacapital.net>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Kees Cook <keescook@chromium.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Oleg Nesterov <oleg@redhat.com>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Cc: Will Drewry <wad@chromium.org>
    Link: http://lkml.kernel.org/r/1428173719-7637-1-git-send-email-dvlasenk@redhat.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    fc3e958a
entry_64.S 41.1 KB