• He Kuang's avatar
    perf tools: Show proper error message for wrong terms of hw/sw events · ffeb883e
    He Kuang authored
    Show proper error message and show valid terms when wrong config terms
    is specified for hw/sw type perf events.
    
    This patch makes the original error format function formats_error_string()
    more generic, which only outputs the static config terms for hw/sw perf
    events, and prepends pmu formats for pmu events.
    
    Before this patch:
    
      $ perf record -e 'cpu-clock/freqx=200/' -a sleep 1
      invalid or unsupported event: 'cpu-clock/freqx=200/'
      Run 'perf list' for a list of valid events
    
       usage: perf record [<options>] [<command>]
          or: perf record [<options>] -- <command> [<options>]
    
          -e, --event <event>   event selector. use 'perf list' to list available events
    
    After this patch:
    
      $ perf record -e 'cpu-clock/freqx=200/' -a sleep 1
      event syntax error: 'cpu-clock/freqx=200/'
                                     \___ unknown term
    
      valid terms: config,config1,config2,name,period,freq,branch_type,time,call-graph,stack-size
    
      Run 'perf list' for a list of valid events
    
       usage: perf record [<options>] [<command>]
          or: perf record [<options>] -- <command> [<options>]
    
          -e, --event <event>   event selector. use 'perf list' to list available events
    Signed-off-by: default avatarHe Kuang <hekuang@huawei.com>
    Acked-by: default avatarJiri Olsa <jolsa@kernel.org>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Kan Liang <kan.liang@intel.com>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Wang Nan <wangnan0@huawei.com>
    Cc: pi3orama@163.com
    Link: http://lkml.kernel.org/r/1443412336-120050-2-git-send-email-hekuang@huawei.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    ffeb883e
parse-events.l 8.21 KB