Commit 002e6745 authored by Christoph Hellwig's avatar Christoph Hellwig

dma-direct: rename dma_noop to dma_direct

The trivial direct mapping implementation already does a virtual to
physical translation which isn't strictly a noop, and will soon learn
to do non-direct but linear physical to dma translations through the
device offset and a few small tricks.  Rename it to a better fitting
name.
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarVladimir Murzin <vladimir.murzin@arm.com>
parent c5cd037d
...@@ -4334,7 +4334,7 @@ T: git git://git.infradead.org/users/hch/dma-mapping.git ...@@ -4334,7 +4334,7 @@ T: git git://git.infradead.org/users/hch/dma-mapping.git
W: http://git.infradead.org/users/hch/dma-mapping.git W: http://git.infradead.org/users/hch/dma-mapping.git
S: Supported S: Supported
F: lib/dma-debug.c F: lib/dma-debug.c
F: lib/dma-noop.c F: lib/dma-direct.c
F: lib/dma-virt.c F: lib/dma-virt.c
F: drivers/base/dma-mapping.c F: drivers/base/dma-mapping.c
F: drivers/base/dma-coherent.c F: drivers/base/dma-coherent.c
......
...@@ -25,7 +25,7 @@ config ARM ...@@ -25,7 +25,7 @@ config ARM
select CLONE_BACKWARDS select CLONE_BACKWARDS
select CPU_PM if (SUSPEND || CPU_IDLE) select CPU_PM if (SUSPEND || CPU_IDLE)
select DCACHE_WORD_ACCESS if HAVE_EFFICIENT_UNALIGNED_ACCESS select DCACHE_WORD_ACCESS if HAVE_EFFICIENT_UNALIGNED_ACCESS
select DMA_NOOP_OPS if !MMU select DMA_DIRECT_OPS if !MMU
select EDAC_SUPPORT select EDAC_SUPPORT
select EDAC_ATOMIC_SCRUB select EDAC_ATOMIC_SCRUB
select GENERIC_ALLOCATOR select GENERIC_ALLOCATOR
......
...@@ -18,7 +18,7 @@ extern const struct dma_map_ops arm_coherent_dma_ops; ...@@ -18,7 +18,7 @@ extern const struct dma_map_ops arm_coherent_dma_ops;
static inline const struct dma_map_ops *get_arch_dma_ops(struct bus_type *bus) static inline const struct dma_map_ops *get_arch_dma_ops(struct bus_type *bus)
{ {
return IS_ENABLED(CONFIG_MMU) ? &arm_dma_ops : &dma_noop_ops; return IS_ENABLED(CONFIG_MMU) ? &arm_dma_ops : &dma_direct_ops;
} }
#ifdef __arch_page_to_dma #ifdef __arch_page_to_dma
......
...@@ -22,7 +22,7 @@ ...@@ -22,7 +22,7 @@
#include "dma.h" #include "dma.h"
/* /*
* dma_noop_ops is used if * dma_direct_ops is used if
* - MMU/MPU is off * - MMU/MPU is off
* - cpu is v7m w/o cache support * - cpu is v7m w/o cache support
* - device is coherent * - device is coherent
...@@ -39,7 +39,7 @@ static void *arm_nommu_dma_alloc(struct device *dev, size_t size, ...@@ -39,7 +39,7 @@ static void *arm_nommu_dma_alloc(struct device *dev, size_t size,
unsigned long attrs) unsigned long attrs)
{ {
const struct dma_map_ops *ops = &dma_noop_ops; const struct dma_map_ops *ops = &dma_direct_ops;
void *ret; void *ret;
/* /*
...@@ -70,7 +70,7 @@ static void arm_nommu_dma_free(struct device *dev, size_t size, ...@@ -70,7 +70,7 @@ static void arm_nommu_dma_free(struct device *dev, size_t size,
void *cpu_addr, dma_addr_t dma_addr, void *cpu_addr, dma_addr_t dma_addr,
unsigned long attrs) unsigned long attrs)
{ {
const struct dma_map_ops *ops = &dma_noop_ops; const struct dma_map_ops *ops = &dma_direct_ops;
if (attrs & DMA_ATTR_NON_CONSISTENT) { if (attrs & DMA_ATTR_NON_CONSISTENT) {
ops->free(dev, size, cpu_addr, dma_addr, attrs); ops->free(dev, size, cpu_addr, dma_addr, attrs);
...@@ -213,7 +213,7 @@ EXPORT_SYMBOL(arm_nommu_dma_ops); ...@@ -213,7 +213,7 @@ EXPORT_SYMBOL(arm_nommu_dma_ops);
static const struct dma_map_ops *arm_nommu_get_dma_map_ops(bool coherent) static const struct dma_map_ops *arm_nommu_get_dma_map_ops(bool coherent)
{ {
return coherent ? &dma_noop_ops : &arm_nommu_dma_ops; return coherent ? &dma_direct_ops : &arm_nommu_dma_ops;
} }
void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size, void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
......
...@@ -19,7 +19,7 @@ config M32R ...@@ -19,7 +19,7 @@ config M32R
select MODULES_USE_ELF_RELA select MODULES_USE_ELF_RELA
select HAVE_DEBUG_STACKOVERFLOW select HAVE_DEBUG_STACKOVERFLOW
select CPU_NO_EFFICIENT_FFS select CPU_NO_EFFICIENT_FFS
select DMA_NOOP_OPS select DMA_DIRECT_OPS
select ARCH_NO_COHERENT_DMA_MMAP if !MMU select ARCH_NO_COHERENT_DMA_MMAP if !MMU
config SBUS config SBUS
......
...@@ -83,7 +83,7 @@ config PGTABLE_LEVELS ...@@ -83,7 +83,7 @@ config PGTABLE_LEVELS
config HAVE_KPROBES config HAVE_KPROBES
def_bool n def_bool n
config DMA_NOOP_OPS config DMA_DIRECT_OPS
def_bool y def_bool y
menu "Platform type" menu "Platform type"
......
...@@ -140,7 +140,7 @@ config S390 ...@@ -140,7 +140,7 @@ config S390
select HAVE_DEBUG_KMEMLEAK select HAVE_DEBUG_KMEMLEAK
select HAVE_DMA_API_DEBUG select HAVE_DMA_API_DEBUG
select HAVE_DMA_CONTIGUOUS select HAVE_DMA_CONTIGUOUS
select DMA_NOOP_OPS select DMA_DIRECT_OPS
select HAVE_DYNAMIC_FTRACE select HAVE_DYNAMIC_FTRACE
select HAVE_DYNAMIC_FTRACE_WITH_REGS select HAVE_DYNAMIC_FTRACE_WITH_REGS
select HAVE_EFFICIENT_UNALIGNED_ACCESS select HAVE_EFFICIENT_UNALIGNED_ACCESS
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
static inline const struct dma_map_ops *get_arch_dma_ops(struct bus_type *bus) static inline const struct dma_map_ops *get_arch_dma_ops(struct bus_type *bus)
{ {
return &dma_noop_ops; return &dma_direct_ops;
} }
#endif /* _ASM_GENERIC_DMA_MAPPING_H */ #endif /* _ASM_GENERIC_DMA_MAPPING_H */
...@@ -136,7 +136,7 @@ struct dma_map_ops { ...@@ -136,7 +136,7 @@ struct dma_map_ops {
int is_phys; int is_phys;
}; };
extern const struct dma_map_ops dma_noop_ops; extern const struct dma_map_ops dma_direct_ops;
extern const struct dma_map_ops dma_virt_ops; extern const struct dma_map_ops dma_virt_ops;
#define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1)) #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
......
...@@ -409,7 +409,7 @@ config HAS_DMA ...@@ -409,7 +409,7 @@ config HAS_DMA
depends on !NO_DMA depends on !NO_DMA
default y default y
config DMA_NOOP_OPS config DMA_DIRECT_OPS
bool bool
depends on HAS_DMA && (!64BIT || ARCH_DMA_ADDR_T_64BIT) depends on HAS_DMA && (!64BIT || ARCH_DMA_ADDR_T_64BIT)
default n default n
......
...@@ -28,7 +28,7 @@ lib-y := ctype.o string.o vsprintf.o cmdline.o \ ...@@ -28,7 +28,7 @@ lib-y := ctype.o string.o vsprintf.o cmdline.o \
lib-$(CONFIG_MMU) += ioremap.o lib-$(CONFIG_MMU) += ioremap.o
lib-$(CONFIG_SMP) += cpumask.o lib-$(CONFIG_SMP) += cpumask.o
lib-$(CONFIG_DMA_NOOP_OPS) += dma-noop.o lib-$(CONFIG_DMA_DIRECT_OPS) += dma-direct.o
lib-$(CONFIG_DMA_VIRT_OPS) += dma-virt.o lib-$(CONFIG_DMA_VIRT_OPS) += dma-virt.o
lib-y += kobject.o klist.o lib-y += kobject.o klist.o
......
...@@ -10,9 +10,8 @@ ...@@ -10,9 +10,8 @@
#include <linux/scatterlist.h> #include <linux/scatterlist.h>
#include <linux/pfn.h> #include <linux/pfn.h>
static void *dma_noop_alloc(struct device *dev, size_t size, static void *dma_direct_alloc(struct device *dev, size_t size,
dma_addr_t *dma_handle, gfp_t gfp, dma_addr_t *dma_handle, gfp_t gfp, unsigned long attrs)
unsigned long attrs)
{ {
void *ret; void *ret;
...@@ -23,24 +22,21 @@ static void *dma_noop_alloc(struct device *dev, size_t size, ...@@ -23,24 +22,21 @@ static void *dma_noop_alloc(struct device *dev, size_t size,
return ret; return ret;
} }
static void dma_noop_free(struct device *dev, size_t size, static void dma_direct_free(struct device *dev, size_t size, void *cpu_addr,
void *cpu_addr, dma_addr_t dma_addr, dma_addr_t dma_addr, unsigned long attrs)
unsigned long attrs)
{ {
free_pages((unsigned long)cpu_addr, get_order(size)); free_pages((unsigned long)cpu_addr, get_order(size));
} }
static dma_addr_t dma_noop_map_page(struct device *dev, struct page *page, static dma_addr_t dma_direct_map_page(struct device *dev, struct page *page,
unsigned long offset, size_t size, unsigned long offset, size_t size, enum dma_data_direction dir,
enum dma_data_direction dir, unsigned long attrs)
unsigned long attrs)
{ {
return page_to_phys(page) + offset - PFN_PHYS(dev->dma_pfn_offset); return page_to_phys(page) + offset - PFN_PHYS(dev->dma_pfn_offset);
} }
static int dma_noop_map_sg(struct device *dev, struct scatterlist *sgl, int nents, static int dma_direct_map_sg(struct device *dev, struct scatterlist *sgl,
enum dma_data_direction dir, int nents, enum dma_data_direction dir, unsigned long attrs)
unsigned long attrs)
{ {
int i; int i;
struct scatterlist *sg; struct scatterlist *sg;
...@@ -58,11 +54,10 @@ static int dma_noop_map_sg(struct device *dev, struct scatterlist *sgl, int nent ...@@ -58,11 +54,10 @@ static int dma_noop_map_sg(struct device *dev, struct scatterlist *sgl, int nent
return nents; return nents;
} }
const struct dma_map_ops dma_noop_ops = { const struct dma_map_ops dma_direct_ops = {
.alloc = dma_noop_alloc, .alloc = dma_direct_alloc,
.free = dma_noop_free, .free = dma_direct_free,
.map_page = dma_noop_map_page, .map_page = dma_direct_map_page,
.map_sg = dma_noop_map_sg, .map_sg = dma_direct_map_sg,
}; };
EXPORT_SYMBOL(dma_direct_ops);
EXPORT_SYMBOL(dma_noop_ops);
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment