Commit 00f333e8 authored by Willem de Bruijn's avatar Willem de Bruijn Committed by David S. Miller

selftests/net: udpgso: test small gso_size boundary conditions

Verify that udpgso can generate segments smaller than device mtu, down
to the extreme case of 1B gso_size.

Verify that irrespective of gso_size, udpgso restricts the number of
segments it will generate per call (UDP_MAX_SEGMENTS).
Signed-off-by: default avatarWillem de Bruijn <willemb@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 830669e6
...@@ -34,6 +34,10 @@ ...@@ -34,6 +34,10 @@
#define UDP_SEGMENT 103 #define UDP_SEGMENT 103
#endif #endif
#ifndef UDP_MAX_SEGMENTS
#define UDP_MAX_SEGMENTS (1 << 6UL)
#endif
#define CONST_MTU_TEST 1500 #define CONST_MTU_TEST 1500
#define CONST_HDRLEN_V4 (sizeof(struct iphdr) + sizeof(struct udphdr)) #define CONST_HDRLEN_V4 (sizeof(struct iphdr) + sizeof(struct udphdr))
...@@ -135,6 +139,38 @@ struct testcase testcases_v4[] = { ...@@ -135,6 +139,38 @@ struct testcase testcases_v4[] = {
.gso_len = CONST_MSS_V4, .gso_len = CONST_MSS_V4,
.tfail = true, .tfail = true,
}, },
{
/* send a single 1B MSS: will fail, see single MSS above */
.tlen = 1,
.gso_len = 1,
.tfail = true,
.r_num_mss = 1,
},
{
/* send 2 1B segments */
.tlen = 2,
.gso_len = 1,
.r_num_mss = 2,
},
{
/* send 2B + 2B + 1B segments */
.tlen = 5,
.gso_len = 2,
.r_num_mss = 2,
.r_len_last = 1,
},
{
/* send max number of min sized segments */
.tlen = UDP_MAX_SEGMENTS - CONST_HDRLEN_V4,
.gso_len = 1,
.r_num_mss = UDP_MAX_SEGMENTS - CONST_HDRLEN_V4,
},
{
/* send max number + 1 of min sized segments: fail */
.tlen = UDP_MAX_SEGMENTS - CONST_HDRLEN_V4 + 1,
.gso_len = 1,
.tfail = true,
},
{ {
/* EOL */ /* EOL */
} }
...@@ -210,6 +246,38 @@ struct testcase testcases_v6[] = { ...@@ -210,6 +246,38 @@ struct testcase testcases_v6[] = {
.gso_len = CONST_MSS_V6, .gso_len = CONST_MSS_V6,
.tfail = true, .tfail = true,
}, },
{
/* send a single 1B MSS: will fail, see single MSS above */
.tlen = 1,
.gso_len = 1,
.tfail = true,
.r_num_mss = 1,
},
{
/* send 2 1B segments */
.tlen = 2,
.gso_len = 1,
.r_num_mss = 2,
},
{
/* send 2B + 2B + 1B segments */
.tlen = 5,
.gso_len = 2,
.r_num_mss = 2,
.r_len_last = 1,
},
{
/* send max number of min sized segments */
.tlen = UDP_MAX_SEGMENTS - CONST_HDRLEN_V6,
.gso_len = 1,
.r_num_mss = UDP_MAX_SEGMENTS - CONST_HDRLEN_V6,
},
{
/* send max number + 1 of min sized segments: fail */
.tlen = UDP_MAX_SEGMENTS - CONST_HDRLEN_V6 + 1,
.gso_len = 1,
.tfail = true,
},
{ {
/* EOL */ /* EOL */
} }
...@@ -375,7 +443,8 @@ static bool __send_one(int fd, struct msghdr *msg, int flags) ...@@ -375,7 +443,8 @@ static bool __send_one(int fd, struct msghdr *msg, int flags)
int ret; int ret;
ret = sendmsg(fd, msg, flags); ret = sendmsg(fd, msg, flags);
if (ret == -1 && (errno == EMSGSIZE || errno == ENOMEM)) if (ret == -1 &&
(errno == EMSGSIZE || errno == ENOMEM || errno == EINVAL))
return false; return false;
if (ret == -1) if (ret == -1)
error(1, errno, "sendmsg"); error(1, errno, "sendmsg");
...@@ -466,7 +535,11 @@ static void run_one(struct testcase *test, int fdt, int fdr, ...@@ -466,7 +535,11 @@ static void run_one(struct testcase *test, int fdt, int fdr,
if (!sent) if (!sent)
return; return;
mss = addr->sa_family == AF_INET ? CONST_MSS_V4 : CONST_MSS_V6; if (test->gso_len)
mss = test->gso_len;
else
mss = addr->sa_family == AF_INET ? CONST_MSS_V4 : CONST_MSS_V6;
/* Recv all full MSS datagrams */ /* Recv all full MSS datagrams */
for (i = 0; i < test->r_num_mss; i++) { for (i = 0; i < test->r_num_mss; i++) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment