Commit 03bd797f authored by Julia Lawall's avatar Julia Lawall Committed by Greg Kroah-Hartman

serial: altera: constify uart_ops structures

Check for uart_ops structures that are only stored in the ops field of a
uart_port structure.  This field is declared const, so uart_ops structures
that have this property can be declared as const also.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct uart_ops i@p = { ... };

@ok@
identifier r.i;
struct uart_port e;
position p;
@@
e.ops = &i@p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct uart_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct uart_ops i = { ... };
// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Acked-by: default avatarTobias Klauser <tklauser@distanz.ch>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5c7dcdb6
...@@ -280,7 +280,7 @@ static int altera_jtaguart_verify_port(struct uart_port *port, ...@@ -280,7 +280,7 @@ static int altera_jtaguart_verify_port(struct uart_port *port,
/* /*
* Define the basic serial functions we support. * Define the basic serial functions we support.
*/ */
static struct uart_ops altera_jtaguart_ops = { static const struct uart_ops altera_jtaguart_ops = {
.tx_empty = altera_jtaguart_tx_empty, .tx_empty = altera_jtaguart_tx_empty,
.get_mctrl = altera_jtaguart_get_mctrl, .get_mctrl = altera_jtaguart_get_mctrl,
.set_mctrl = altera_jtaguart_set_mctrl, .set_mctrl = altera_jtaguart_set_mctrl,
......
...@@ -404,7 +404,7 @@ static void altera_uart_poll_put_char(struct uart_port *port, unsigned char c) ...@@ -404,7 +404,7 @@ static void altera_uart_poll_put_char(struct uart_port *port, unsigned char c)
/* /*
* Define the basic serial functions we support. * Define the basic serial functions we support.
*/ */
static struct uart_ops altera_uart_ops = { static const struct uart_ops altera_uart_ops = {
.tx_empty = altera_uart_tx_empty, .tx_empty = altera_uart_tx_empty,
.get_mctrl = altera_uart_get_mctrl, .get_mctrl = altera_uart_get_mctrl,
.set_mctrl = altera_uart_set_mctrl, .set_mctrl = altera_uart_set_mctrl,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment