Commit 047d6d84 authored by Amitoj Kaur Chawla's avatar Amitoj Kaur Chawla Committed by Thierry Reding

clk: tegra: Add missing of_node_put()

for_each_child_of_node() performs an of_node_get() on each iteration, so
before breaking out of the loop an of_node_put() is required.

Found using Coccinelle. The semantic patch used for this is as follows:

// <smpl>
@@
expression e;
local idexpression child;
@@

 for_each_child_of_node(root, child) {
   ... when != of_node_put(child)
       when != e = child
(
   return child;
|
+  of_node_put(child);
?  return ...;
)
   ...
 }
// </smpl>
Signed-off-by: default avatarAmitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent 442f53fb
...@@ -450,8 +450,10 @@ static int load_timings_from_dt(struct tegra_clk_emc *tegra, ...@@ -450,8 +450,10 @@ static int load_timings_from_dt(struct tegra_clk_emc *tegra,
struct emc_timing *timing = tegra->timings + (i++); struct emc_timing *timing = tegra->timings + (i++);
err = load_one_timing_from_dt(tegra, timing, child); err = load_one_timing_from_dt(tegra, timing, child);
if (err) if (err) {
of_node_put(child);
return err; return err;
}
timing->ram_code = ram_code; timing->ram_code = ram_code;
} }
...@@ -499,9 +501,9 @@ struct clk *tegra_clk_register_emc(void __iomem *base, struct device_node *np, ...@@ -499,9 +501,9 @@ struct clk *tegra_clk_register_emc(void __iomem *base, struct device_node *np,
* fuses until the apbmisc driver is loaded. * fuses until the apbmisc driver is loaded.
*/ */
err = load_timings_from_dt(tegra, node, node_ram_code); err = load_timings_from_dt(tegra, node, node_ram_code);
of_node_put(node);
if (err) if (err)
return ERR_PTR(err); return ERR_PTR(err);
of_node_put(node);
break; break;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment