Commit 04fd4cb0 authored by Kai-Heng Feng's avatar Kai-Heng Feng Committed by Jiri Kosina

HID: alps: fix stick device not working after resume

The stick device does not work after resume, add U1_SP_ABS_MODE flag can
make the device work after resume.

This has been discovered by pure guesswork, based on how the existing code uses
U1_TP_ABS_MODE flag on both initialization and resume.

I also tested the the patch on an ALPS touchpad without stick device, did not
notice any side effect on suspend/resume, so I made the U1_SP_ABS_MODE flag
mandatory.

[jkosina@suse.cz: made changelog more verbose]
Signed-off-by: default avatarKai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 7ee2eaa3
...@@ -245,13 +245,13 @@ static int alps_raw_event(struct hid_device *hdev, ...@@ -245,13 +245,13 @@ static int alps_raw_event(struct hid_device *hdev,
static int alps_post_reset(struct hid_device *hdev) static int alps_post_reset(struct hid_device *hdev)
{ {
return u1_read_write_register(hdev, ADDRESS_U1_DEV_CTRL_1, return u1_read_write_register(hdev, ADDRESS_U1_DEV_CTRL_1,
NULL, U1_TP_ABS_MODE, false); NULL, U1_TP_ABS_MODE | U1_SP_ABS_MODE, false);
} }
static int alps_post_resume(struct hid_device *hdev) static int alps_post_resume(struct hid_device *hdev)
{ {
return u1_read_write_register(hdev, ADDRESS_U1_DEV_CTRL_1, return u1_read_write_register(hdev, ADDRESS_U1_DEV_CTRL_1,
NULL, U1_TP_ABS_MODE, false); NULL, U1_TP_ABS_MODE | U1_SP_ABS_MODE, false);
} }
#endif /* CONFIG_PM */ #endif /* CONFIG_PM */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment