Commit 05b43971 authored by Y.C. Chen's avatar Y.C. Chen Committed by Dave Airlie

drm/ast: Fixed reboot test may cause system hanged

There is another thread still access standard VGA I/O while loading drm driver.
Disable standard VGA I/O decode to avoid this issue.
Signed-off-by: default avatarY.C. Chen <yc_chen@aspeedtech.com>
Reviewed-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1523410059-18415-1-git-send-email-yc_chen@aspeedtech.com
parent d45331b0
...@@ -131,8 +131,8 @@ static int ast_detect_chip(struct drm_device *dev, bool *need_post) ...@@ -131,8 +131,8 @@ static int ast_detect_chip(struct drm_device *dev, bool *need_post)
/* Enable extended register access */ /* Enable extended register access */
ast_enable_mmio(dev);
ast_open_key(ast); ast_open_key(ast);
ast_enable_mmio(dev);
/* Find out whether P2A works or whether to use device-tree */ /* Find out whether P2A works or whether to use device-tree */
ast_detect_config_mode(dev, &scu_rev); ast_detect_config_mode(dev, &scu_rev);
...@@ -576,6 +576,9 @@ void ast_driver_unload(struct drm_device *dev) ...@@ -576,6 +576,9 @@ void ast_driver_unload(struct drm_device *dev)
{ {
struct ast_private *ast = dev->dev_private; struct ast_private *ast = dev->dev_private;
/* enable standard VGA decode */
ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa1, 0x04);
ast_release_firmware(dev); ast_release_firmware(dev);
kfree(ast->dp501_fw_addr); kfree(ast->dp501_fw_addr);
ast_mode_fini(dev); ast_mode_fini(dev);
......
...@@ -604,7 +604,7 @@ static int ast_crtc_mode_set(struct drm_crtc *crtc, ...@@ -604,7 +604,7 @@ static int ast_crtc_mode_set(struct drm_crtc *crtc,
return -EINVAL; return -EINVAL;
ast_open_key(ast); ast_open_key(ast);
ast_set_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xa1, 0xff, 0x04); ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa1, 0x06);
ast_set_std_reg(crtc, adjusted_mode, &vbios_mode); ast_set_std_reg(crtc, adjusted_mode, &vbios_mode);
ast_set_crtc_reg(crtc, adjusted_mode, &vbios_mode); ast_set_crtc_reg(crtc, adjusted_mode, &vbios_mode);
......
...@@ -46,7 +46,7 @@ void ast_enable_mmio(struct drm_device *dev) ...@@ -46,7 +46,7 @@ void ast_enable_mmio(struct drm_device *dev)
{ {
struct ast_private *ast = dev->dev_private; struct ast_private *ast = dev->dev_private;
ast_set_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xa1, 0xff, 0x04); ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xa1, 0x06);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment