Commit 0702099b authored by J. R. Okajima's avatar J. R. Okajima Committed by Trond Myklebust

NFS: fix the return value of nfs_file_fsync()

By the commit af7fa165 2010-08-03 NFS: Fix up the fsync code
close(2) became returning the non-zero value even if it went well.
nfs_file_fsync() should return 0 when "status" is positive.
Signed-off-by: default avatarJ. R. Okajima <hooanon05@yahoo.co.jp>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent 15cdc644
...@@ -323,7 +323,7 @@ nfs_file_fsync(struct file *file, int datasync) ...@@ -323,7 +323,7 @@ nfs_file_fsync(struct file *file, int datasync)
have_error |= test_bit(NFS_CONTEXT_ERROR_WRITE, &ctx->flags); have_error |= test_bit(NFS_CONTEXT_ERROR_WRITE, &ctx->flags);
if (have_error) if (have_error)
ret = xchg(&ctx->error, 0); ret = xchg(&ctx->error, 0);
if (!ret) if (!ret && status < 0)
ret = status; ret = status;
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment