[PATCH] I2C: make I2C chip drivers return -EINVAL on error

drivers/i2c/chips/fscher.c

@@ -512,7 +512,7 @@ static ssize_t set_fan_div(struct i2c_client *client, struct fscher_data *data,
 	default:
 		dev_err(&client->dev, "fan_div value %ld not "
 			 "supported. Choose one of 2, 4 or 8!\n", v);
-		return -1;
+		return -EINVAL;
 	}
 
 	/* bits 2..7 reserved => mask with 0x03 */

drivers/i2c/chips/it87.c

@@ -367,7 +367,7 @@ static ssize_t set_sensor(struct device *dev, const char *buf,
 	else if (val == 2)
 	    data->sensor |= 8 << nr;
 	else if (val != 0)
-		return -1;
+		return -EINVAL;
 	it87_write_value(client, IT87_REG_TEMP_ENABLE, data->sensor);
 	return count;
 }

drivers/i2c/chips/pcf8591.c

@@ -129,8 +129,9 @@ static ssize_t set_out0_output(struct device *dev, const char *buf, size_t count
 	if ((value = (simple_strtoul(buf, NULL, 10) + 5) / 10) <= 255) {
 		data->aout = value;
 		i2c_smbus_write_byte_data(client, data->control, data->aout);
+		return count;
 	}
-	return count;
+	return -EINVAL;
 }
 
 static DEVICE_ATTR(out0_output, S_IWUSR | S_IRUGO,