Commit 07c8fedd authored by Dave Airlie's avatar Dave Airlie

Merge branch 'exynos-drm-fixes' of...

Merge branch 'exynos-drm-fixes' of git://git.kernel.org:/pub/scm/linux/kernel/git/daeinki/drm-exynos into drm-fixes

  Just regression fixes.
   - Fix build warning and error without PM configuration
   - Fix no display issue on Snow board reported by Michal Suchanek,
     http://www.spinics.net/lists/dri-devel/msg99473.html

* 'exynos-drm-fixes' of git://git.kernel.org:/pub/scm/linux/kernel/git/daeinki/drm-exynos:
  drm/exynos: dp: Fix panel and bridge lookup logic
  drm: exynos: make PM functions as __maybe_unused
  drm/exynos: fix building without CONFIG_PM_SLEEP
parents c6b431cc 37e11062
...@@ -1392,7 +1392,7 @@ static const struct component_ops exynos_dp_ops = { ...@@ -1392,7 +1392,7 @@ static const struct component_ops exynos_dp_ops = {
static int exynos_dp_probe(struct platform_device *pdev) static int exynos_dp_probe(struct platform_device *pdev)
{ {
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
struct device_node *panel_node = NULL, *bridge_node, *endpoint = NULL; struct device_node *np = NULL, *endpoint = NULL;
struct exynos_dp_device *dp; struct exynos_dp_device *dp;
int ret; int ret;
...@@ -1404,41 +1404,36 @@ static int exynos_dp_probe(struct platform_device *pdev) ...@@ -1404,41 +1404,36 @@ static int exynos_dp_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, dp); platform_set_drvdata(pdev, dp);
/* This is for the backward compatibility. */ /* This is for the backward compatibility. */
panel_node = of_parse_phandle(dev->of_node, "panel", 0); np = of_parse_phandle(dev->of_node, "panel", 0);
if (panel_node) { if (np) {
dp->panel = of_drm_find_panel(panel_node); dp->panel = of_drm_find_panel(np);
of_node_put(panel_node); of_node_put(np);
if (!dp->panel) if (!dp->panel)
return -EPROBE_DEFER; return -EPROBE_DEFER;
} else {
endpoint = of_graph_get_next_endpoint(dev->of_node, NULL);
if (endpoint) {
panel_node = of_graph_get_remote_port_parent(endpoint);
if (panel_node) {
dp->panel = of_drm_find_panel(panel_node);
of_node_put(panel_node);
if (!dp->panel)
return -EPROBE_DEFER;
} else {
DRM_ERROR("no port node for panel device.\n");
return -EINVAL;
}
}
}
if (endpoint)
goto out; goto out;
}
endpoint = of_graph_get_next_endpoint(dev->of_node, NULL); endpoint = of_graph_get_next_endpoint(dev->of_node, NULL);
if (endpoint) { if (endpoint) {
bridge_node = of_graph_get_remote_port_parent(endpoint); np = of_graph_get_remote_port_parent(endpoint);
if (bridge_node) { if (np) {
dp->ptn_bridge = of_drm_find_bridge(bridge_node); /* The remote port can be either a panel or a bridge */
of_node_put(bridge_node); dp->panel = of_drm_find_panel(np);
if (!dp->ptn_bridge) if (!dp->panel) {
return -EPROBE_DEFER; dp->ptn_bridge = of_drm_find_bridge(np);
} else if (!dp->ptn_bridge) {
return -EPROBE_DEFER; of_node_put(np);
return -EPROBE_DEFER;
}
}
of_node_put(np);
} else {
DRM_ERROR("no remote endpoint device node found.\n");
return -EINVAL;
}
} else {
DRM_ERROR("no port endpoint subnode found.\n");
return -EINVAL;
} }
out: out:
......
...@@ -1906,8 +1906,7 @@ static int exynos_dsi_remove(struct platform_device *pdev) ...@@ -1906,8 +1906,7 @@ static int exynos_dsi_remove(struct platform_device *pdev)
return 0; return 0;
} }
#ifdef CONFIG_PM static int __maybe_unused exynos_dsi_suspend(struct device *dev)
static int exynos_dsi_suspend(struct device *dev)
{ {
struct drm_encoder *encoder = dev_get_drvdata(dev); struct drm_encoder *encoder = dev_get_drvdata(dev);
struct exynos_dsi *dsi = encoder_to_dsi(encoder); struct exynos_dsi *dsi = encoder_to_dsi(encoder);
...@@ -1938,7 +1937,7 @@ static int exynos_dsi_suspend(struct device *dev) ...@@ -1938,7 +1937,7 @@ static int exynos_dsi_suspend(struct device *dev)
return 0; return 0;
} }
static int exynos_dsi_resume(struct device *dev) static int __maybe_unused exynos_dsi_resume(struct device *dev)
{ {
struct drm_encoder *encoder = dev_get_drvdata(dev); struct drm_encoder *encoder = dev_get_drvdata(dev);
struct exynos_dsi *dsi = encoder_to_dsi(encoder); struct exynos_dsi *dsi = encoder_to_dsi(encoder);
...@@ -1972,7 +1971,6 @@ static int exynos_dsi_resume(struct device *dev) ...@@ -1972,7 +1971,6 @@ static int exynos_dsi_resume(struct device *dev)
return ret; return ret;
} }
#endif
static const struct dev_pm_ops exynos_dsi_pm_ops = { static const struct dev_pm_ops exynos_dsi_pm_ops = {
SET_RUNTIME_PM_OPS(exynos_dsi_suspend, exynos_dsi_resume, NULL) SET_RUNTIME_PM_OPS(exynos_dsi_suspend, exynos_dsi_resume, NULL)
......
...@@ -1289,8 +1289,7 @@ static int mixer_remove(struct platform_device *pdev) ...@@ -1289,8 +1289,7 @@ static int mixer_remove(struct platform_device *pdev)
return 0; return 0;
} }
#ifdef CONFIG_PM_SLEEP static int __maybe_unused exynos_mixer_suspend(struct device *dev)
static int exynos_mixer_suspend(struct device *dev)
{ {
struct mixer_context *ctx = dev_get_drvdata(dev); struct mixer_context *ctx = dev_get_drvdata(dev);
struct mixer_resources *res = &ctx->mixer_res; struct mixer_resources *res = &ctx->mixer_res;
...@@ -1306,7 +1305,7 @@ static int exynos_mixer_suspend(struct device *dev) ...@@ -1306,7 +1305,7 @@ static int exynos_mixer_suspend(struct device *dev)
return 0; return 0;
} }
static int exynos_mixer_resume(struct device *dev) static int __maybe_unused exynos_mixer_resume(struct device *dev)
{ {
struct mixer_context *ctx = dev_get_drvdata(dev); struct mixer_context *ctx = dev_get_drvdata(dev);
struct mixer_resources *res = &ctx->mixer_res; struct mixer_resources *res = &ctx->mixer_res;
...@@ -1342,7 +1341,6 @@ static int exynos_mixer_resume(struct device *dev) ...@@ -1342,7 +1341,6 @@ static int exynos_mixer_resume(struct device *dev)
return 0; return 0;
} }
#endif
static const struct dev_pm_ops exynos_mixer_pm_ops = { static const struct dev_pm_ops exynos_mixer_pm_ops = {
SET_RUNTIME_PM_OPS(exynos_mixer_suspend, exynos_mixer_resume, NULL) SET_RUNTIME_PM_OPS(exynos_mixer_suspend, exynos_mixer_resume, NULL)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment