Commit 08a24034 authored by Daniel Vetter's avatar Daniel Vetter

drm/i915: introduce macros to check pipe config properties

This code will get _really_ repetive, and we'll end up with tons more
of this kind. So extract the common patterns.

This should also help when we add a lazy pipe_config compare mode for
fastboot.
Reviewed-by: default avatarMika Kuoppala <mika.kuoppala@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 0973f18f
...@@ -7949,21 +7949,19 @@ static bool ...@@ -7949,21 +7949,19 @@ static bool
intel_pipe_config_compare(struct intel_crtc_config *current_config, intel_pipe_config_compare(struct intel_crtc_config *current_config,
struct intel_crtc_config *pipe_config) struct intel_crtc_config *pipe_config)
{ {
if (current_config->has_pch_encoder != pipe_config->has_pch_encoder) { #define PIPE_CONF_CHECK_I(name) \
DRM_ERROR("mismatch in has_pch_encoder " if (current_config->name != pipe_config->name) { \
"(expected %i, found %i)\n", DRM_ERROR("mismatch in " #name " " \
current_config->has_pch_encoder, "(expected %i, found %i)\n", \
pipe_config->has_pch_encoder); current_config->name, \
return false; pipe_config->name); \
return false; \
} }
if (current_config->fdi_lanes != pipe_config->fdi_lanes) { PIPE_CONF_CHECK_I(has_pch_encoder);
DRM_ERROR("mismatch in fdi_lanes " PIPE_CONF_CHECK_I(fdi_lanes);
"(expected %i, found %i)\n",
current_config->fdi_lanes, #undef PIPE_CONF_CHECK_I
pipe_config->fdi_lanes);
return false;
}
return true; return true;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment