Commit 0a020022 authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Jean Delvare

hwmon: (ams) Fix permissions on 'joystick' module parameter

We should not allow writes to the 'joystick' module parameters since
writing there will not trigger creation of the input device. Disable
writes since we provide alternative way of enabling input device via
AMS device's sysfs attribute.
Signed-off-by: default avatarDmitry Torokhov <dtor@mail.ru>
Acked-by: default avatarJohannes Berg <johannes@sipsolutions.net>
Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
parent 810ad7b6
...@@ -20,11 +20,11 @@ ...@@ -20,11 +20,11 @@
#include "ams.h" #include "ams.h"
static unsigned int joystick; static unsigned int joystick;
module_param(joystick, bool, 0644); module_param(joystick, bool, S_IRUGO);
MODULE_PARM_DESC(joystick, "Enable the input class device on module load"); MODULE_PARM_DESC(joystick, "Enable the input class device on module load");
static unsigned int invert; static unsigned int invert;
module_param(invert, bool, 0644); module_param(invert, bool, S_IWUSR | S_IRUGO);
MODULE_PARM_DESC(invert, "Invert input data on X and Y axis"); MODULE_PARM_DESC(invert, "Invert input data on X and Y axis");
static void ams_idev_poll(struct input_polled_dev *dev) static void ams_idev_poll(struct input_polled_dev *dev)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment