Commit 0b26985a authored by Colin Ian King's avatar Colin Ian King Committed by Rafael J. Wysocki

PM / clk: ensure we don't allocate a -ve size of count clks

It is entirely possible for of_count_phandle_wit_args to
return a -ve error return value so we need to check for this
otherwise we end up allocating a negative number of clk objects.
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-by: default avatarPavel Machek <pavel@ucw.cz>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 02da2d72
...@@ -159,7 +159,7 @@ int of_pm_clk_add_clks(struct device *dev) ...@@ -159,7 +159,7 @@ int of_pm_clk_add_clks(struct device *dev)
count = of_count_phandle_with_args(dev->of_node, "clocks", count = of_count_phandle_with_args(dev->of_node, "clocks",
"#clock-cells"); "#clock-cells");
if (count == 0) if (count <= 0)
return -ENODEV; return -ENODEV;
clks = kcalloc(count, sizeof(*clks), GFP_KERNEL); clks = kcalloc(count, sizeof(*clks), GFP_KERNEL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment