Commit 0c51ef86 authored by Noralf Trønnes's avatar Noralf Trønnes Committed by Jani Nikula

drm/debugfs: Fix framebuffer debugfs file init

The introduction of: drm/framebuffer: Add framebuffer debugfs file
broke vgem. That patch assumed that all drivers had initialized the
dev->mode_config.fb_lock mutex which happens in drm_mode_config_init().
vgem doesn't need to call drm_mode_config_init().

Fix this by only creating the framebuffer debugfs file for modesetting
drivers.

Fixes: 45d58b40 ("drm/framebuffer: Add framebuffer debugfs file")
Suggested-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: default avatarNoralf Trønnes <noralf@tronnes.org>
Reviewed-by: default avatarDave Airlie <airlied@redhat.com>
Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171113231201.26177-1-noralf@tronnes.org
parent 5d276a1a
...@@ -158,10 +158,12 @@ int drm_debugfs_init(struct drm_minor *minor, int minor_id, ...@@ -158,10 +158,12 @@ int drm_debugfs_init(struct drm_minor *minor, int minor_id,
} }
} }
ret = drm_framebuffer_debugfs_init(minor); if (drm_core_check_feature(dev, DRIVER_MODESET)) {
if (ret) { ret = drm_framebuffer_debugfs_init(minor);
DRM_ERROR("Failed to create framebuffer debugfs file\n"); if (ret) {
return ret; DRM_ERROR("Failed to create framebuffer debugfs file\n");
return ret;
}
} }
if (dev->driver->debugfs_init) { if (dev->driver->debugfs_init) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment