Commit 0ce7d00d authored by Axel Lin's avatar Axel Lin Committed by Mark Brown

regulator: tps6507x: Fix using wrong dev argument for calling of_regulator_match

The dev parameter is the device requesting the data.
In this case it should be &pdev->dev rather than pdev->dev.parent.

The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(),
which means this fixes a memory leak because the memory is allocated every time
probe() is called, thus it should be freed when this driver is unloaded.
Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent 6116ad94
...@@ -394,7 +394,7 @@ static struct tps6507x_board *tps6507x_parse_dt_reg_data( ...@@ -394,7 +394,7 @@ static struct tps6507x_board *tps6507x_parse_dt_reg_data(
count = ARRAY_SIZE(tps6507x_matches); count = ARRAY_SIZE(tps6507x_matches);
matches = tps6507x_matches; matches = tps6507x_matches;
ret = of_regulator_match(pdev->dev.parent, regulators, matches, count); ret = of_regulator_match(&pdev->dev, regulators, matches, count);
if (ret < 0) { if (ret < 0) {
dev_err(&pdev->dev, "Error parsing regulator init data: %d\n", dev_err(&pdev->dev, "Error parsing regulator init data: %d\n",
ret); ret);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment