Commit 0e083662 authored by Christian Lütke-Stetzkamp's avatar Christian Lütke-Stetzkamp Committed by Greg Kroah-Hartman

staging: mt7621-mmc: Fix: copy_from_user() returns a positive value

copy_from_user() returns a positive value in case of an error, to fix
this the check is turned around, also a better return value is chosen.
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Suggested-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarChristian Lütke-Stetzkamp <christian@lkamp.de>
Reviewed-by: default avatarNeilBrown <neil@brown.name>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2436c315
...@@ -265,9 +265,8 @@ static ssize_t msdc_debug_proc_write(struct file *file, ...@@ -265,9 +265,8 @@ static ssize_t msdc_debug_proc_write(struct file *file,
if (count > 255) if (count > 255)
count = 255; count = 255;
ret = copy_from_user(cmd_buf, buf, count); if (copy_from_user(cmd_buf, buf, count))
if (ret < 0) return -EFAULT;
return -1;
cmd_buf[count] = '\0'; cmd_buf[count] = '\0';
printk("msdc Write %s\n", cmd_buf); printk("msdc Write %s\n", cmd_buf);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment