Commit 104b2d87 authored by Sudip Mukherjee's avatar Sudip Mukherjee Committed by Alexandre Belloni

rtc: m41t80: use devm_add_action_or_reset()

If devm_add_action() fails we are explicitly calling the cleanup to free
the resources allocated.  Lets use the helper devm_add_action_or_reset()
and return directly in case of error, as we know that the cleanup function
has been already called by the helper if there was any error.
Signed-off-by: default avatarSudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
parent 6785b3b6
...@@ -829,10 +829,9 @@ static int m41t80_probe(struct i2c_client *client, ...@@ -829,10 +829,9 @@ static int m41t80_probe(struct i2c_client *client,
return rc; return rc;
} }
rc = devm_add_action(&client->dev, m41t80_remove_sysfs_group, rc = devm_add_action_or_reset(&client->dev, m41t80_remove_sysfs_group,
&client->dev); &client->dev);
if (rc) { if (rc) {
m41t80_remove_sysfs_group(&client->dev);
dev_err(&client->dev, dev_err(&client->dev,
"Failed to add sysfs cleanup action: %d\n", rc); "Failed to add sysfs cleanup action: %d\n", rc);
return rc; return rc;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment