Commit 1074d683 authored by Guenter Roeck's avatar Guenter Roeck

hwmon: (lm78) Fix overflow problems seen when writing large temperature limits

On platforms with sizeof(int) < sizeof(long), writing a temperature
limit larger than MAXINT will result in unpredictable limit values
written to the chip. Avoid auto-conversion from long to int to fix
the problem.

Cc: Axel Lin <axel.lin@ingics.com>
Cc: stable@vger.kernel.org
Reviewed-by: default avatarAxel Lin <axel.lin@ingics.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 3248c3b7
...@@ -108,7 +108,7 @@ static inline int FAN_FROM_REG(u8 val, int div) ...@@ -108,7 +108,7 @@ static inline int FAN_FROM_REG(u8 val, int div)
* TEMP: mC (-128C to +127C) * TEMP: mC (-128C to +127C)
* REG: 1C/bit, two's complement * REG: 1C/bit, two's complement
*/ */
static inline s8 TEMP_TO_REG(int val) static inline s8 TEMP_TO_REG(long val)
{ {
int nval = clamp_val(val, -128000, 127000) ; int nval = clamp_val(val, -128000, 127000) ;
return nval < 0 ? (nval - 500) / 1000 : (nval + 500) / 1000; return nval < 0 ? (nval - 500) / 1000 : (nval + 500) / 1000;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment