Commit 10a599fa authored by Ville Syrjälä's avatar Ville Syrjälä

drm/atomic-helper: WARN if fake_commit->hw_done is not completed as expected

For real commits we WARN if ->hw_done hasn't been completed by the time
drm_atomic_helper_commit_cleanup_done() is called. Let's do the same for
the fake commit.
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181122143412.11655-2-ville.syrjala@linux.intel.comReviewed-by: default avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
parent 2de42f79
...@@ -2216,8 +2216,10 @@ void drm_atomic_helper_commit_cleanup_done(struct drm_atomic_state *old_state) ...@@ -2216,8 +2216,10 @@ void drm_atomic_helper_commit_cleanup_done(struct drm_atomic_state *old_state)
spin_unlock(&crtc->commit_lock); spin_unlock(&crtc->commit_lock);
} }
if (old_state->fake_commit) if (old_state->fake_commit) {
complete_all(&old_state->fake_commit->cleanup_done); complete_all(&old_state->fake_commit->cleanup_done);
WARN_ON(!try_wait_for_completion(&old_state->fake_commit->hw_done));
}
} }
EXPORT_SYMBOL(drm_atomic_helper_commit_cleanup_done); EXPORT_SYMBOL(drm_atomic_helper_commit_cleanup_done);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment