Commit 11b26af7 authored by Rusty Russell's avatar Rusty Russell Committed by Linus Torvalds

[PATCH] Shut up about the damn modules already...

In almost all distributions, the kernel asks for modules which don't
exist, such as "net-pf-10" or whatever.  Changing "modprobe -q" to
"succeed" in this case is hacky and breaks some setups, and also we
want to know if it failed for the fallback code for old aliases in
fs/char_dev.c, for example.

Just remove the debugging message which fill people's logs: the
correct way of debugging module problems is something like this:

	echo '#! /bin/sh' > /tmp/modprobe
	echo 'echo "$@" >> /tmp/modprobe.log' >> /tmp/modprobe
	echo 'exec /sbin/modprobe "$@"' >> /tmp/modprobe
	chmod a+x /tmp/modprobe
	echo /tmp/modprobe > /proc/sys/kernel/modprobe
parent bfb17dbd
...@@ -105,16 +105,6 @@ int request_module(const char *fmt, ...) ...@@ -105,16 +105,6 @@ int request_module(const char *fmt, ...)
} }
ret = call_usermodehelper(modprobe_path, argv, envp, 1); ret = call_usermodehelper(modprobe_path, argv, envp, 1);
if (ret != 0) {
static unsigned long last;
unsigned long now = jiffies;
if (now - last > HZ) {
last = now;
printk(KERN_DEBUG
"request_module: failed %s -- %s. error = %d\n",
modprobe_path, module_name, ret);
}
}
atomic_dec(&kmod_concurrent); atomic_dec(&kmod_concurrent);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment