Commit 12e3ffb9 authored by Stanley Chu's avatar Stanley Chu Committed by Martin K. Petersen

scsi: ufs: Change "<name>-max-microamp" to non-mandatory property

In dt-bindings for ufs, "<name>-max-microamp" property indicates current
limit and is mandatory if "<name>-fixed-regulator" is not defined on a
specified regulator.

However, in some platforms, regulators without "<name>-fixed-regulator"
property may not need to define their current limit because they may want
to define voltage range only for proper voltage switching in different
power modes, especially for vcc, vccq or vccq2.

Currently missing "<name>-max-microamp" property in device tree will lead
initialization to fail, thus such limitation shall be resolved to tolerate
this kind of regulators.

After resolving this, regulators without "<name>-max-microamp" property
will have undefined "max current" value, i.e., zero value in "max_uA" field
in struct ufs_vreg. Because we do bypass current switching operation (by
regulator_set_load) in case of undefined current limit, this patch shall be
safe.
Signed-off-by: default avatarStanley Chu <stanley.chu@mediatek.com>
Reviewed-by: default avatarAvri Altman <avri.altman@wdc.com>
Acked-by: default avatarAlim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 0487fff7
...@@ -158,11 +158,9 @@ static int ufshcd_populate_vreg(struct device *dev, const char *name, ...@@ -158,11 +158,9 @@ static int ufshcd_populate_vreg(struct device *dev, const char *name,
goto out; goto out;
snprintf(prop_name, MAX_PROP_SIZE, "%s-max-microamp", name); snprintf(prop_name, MAX_PROP_SIZE, "%s-max-microamp", name);
ret = of_property_read_u32(np, prop_name, &vreg->max_uA); if (of_property_read_u32(np, prop_name, &vreg->max_uA)) {
if (ret) { dev_info(dev, "%s: unable to find %s\n", __func__, prop_name);
dev_err(dev, "%s: unable to find %s err %d\n", vreg->max_uA = 0;
__func__, prop_name, ret);
goto out;
} }
if (!strcmp(name, "vcc")) { if (!strcmp(name, "vcc")) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment