Commit 13174c38 authored by Pan Bian's avatar Pan Bian Committed by Mauro Carvalho Chehab

[media] m5602_s5k83a: check return value of kthread_create

Function kthread_create() returns an ERR_PTR on error. However, in
function s5k83a_start(), its return value is used without validation.
This may result in a bad memory access bug. This patch fixes the bug.
Signed-off-by: default avatarPan Bian <bianpan2016@163.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent d90b336f
...@@ -345,6 +345,11 @@ int s5k83a_start(struct sd *sd) ...@@ -345,6 +345,11 @@ int s5k83a_start(struct sd *sd)
to assume that there is no better way of accomplishing this */ to assume that there is no better way of accomplishing this */
sd->rotation_thread = kthread_create(rotation_thread_function, sd->rotation_thread = kthread_create(rotation_thread_function,
sd, "rotation thread"); sd, "rotation thread");
if (IS_ERR(sd->rotation_thread)) {
err = PTR_ERR(sd->rotation_thread);
sd->rotation_thread = NULL;
return err;
}
wake_up_process(sd->rotation_thread); wake_up_process(sd->rotation_thread);
/* Preinit the sensor */ /* Preinit the sensor */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment