Commit 15d8061b authored by Benjamin Herrenschmidt's avatar Benjamin Herrenschmidt Committed by Bartlomiej Zolnierkiewicz

ide: Fix cs5535 driver accessing beyond array boundary

The cs5535 uses an incorrect construct to access the other drive of a pair,
causing it to access beyond an array boundary on the secondary interface.

This fixes it by using the new ide_get_paired_drive() helper instead.

Bart: patch description fixes
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>
Acked-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
parent a87a87cc
...@@ -84,7 +84,7 @@ static void cs5535_set_speed(ide_drive_t *drive, const u8 speed) ...@@ -84,7 +84,7 @@ static void cs5535_set_speed(ide_drive_t *drive, const u8 speed)
/* Set the PIO timings */ /* Set the PIO timings */
if ((speed & XFER_MODE) == XFER_PIO) { if ((speed & XFER_MODE) == XFER_PIO) {
ide_drive_t *pair = &drive->hwif->drives[drive->dn ^ 1]; ide_drive_t *pair = ide_get_paired_drive(drive);
u8 cmd, pioa; u8 cmd, pioa;
cmd = pioa = speed - XFER_PIO_0; cmd = pioa = speed - XFER_PIO_0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment