Commit 1734bffc authored by Michael S. Tsirkin's avatar Michael S. Tsirkin

blackfin: fix put_user sparse errors

virtio wants to write bitwise types to userspace using put_user.
At the moment this triggers sparse errors, since the value is passed
through an integer.

For example:

	__le32 __user *p;
	__le32 x;
	put_user(x, p);

is safe, but currently triggers a sparse warning.

Fix that up using __force.

Note: this does not suppress any useful sparse checks since caller
assigns x to typeof(*p), which in turn forces all the necessary type
checks.
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent e8b94dea
...@@ -89,10 +89,10 @@ struct exception_table_entry { ...@@ -89,10 +89,10 @@ struct exception_table_entry {
break; \ break; \
case 8: { \ case 8: { \
long _xl, _xh; \ long _xl, _xh; \
_xl = ((long *)&_x)[0]; \ _xl = ((__force long *)&_x)[0]; \
_xh = ((long *)&_x)[1]; \ _xh = ((__force long *)&_x)[1]; \
__put_user_asm(_xl, ((long __user *)_p)+0, ); \ __put_user_asm(_xl, ((__force long __user *)_p)+0, );\
__put_user_asm(_xh, ((long __user *)_p)+1, ); \ __put_user_asm(_xh, ((__force long __user *)_p)+1, );\
} break; \ } break; \
default: \ default: \
_err = __put_user_bad(); \ _err = __put_user_bad(); \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment