Commit 174122c3 authored by Ard Biesheuvel's avatar Ard Biesheuvel Committed by Herbert Xu

crypto: arm64/sha2-ce - fix for big endian

The SHA256 digest is an array of 8 32-bit quantities, so we should refer
to them as such in order for this code to work correctly when built for
big endian. So replace 16 byte scalar loads and stores with 4x32 vector
ones where appropriate.

Fixes: 6ba6c74d ("arm64/crypto: SHA-224/SHA-256 using ARMv8 Crypto Extensions")
Signed-off-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent ee71e5f1
...@@ -85,7 +85,7 @@ ENTRY(sha2_ce_transform) ...@@ -85,7 +85,7 @@ ENTRY(sha2_ce_transform)
ld1 {v12.4s-v15.4s}, [x8] ld1 {v12.4s-v15.4s}, [x8]
/* load state */ /* load state */
ldp dga, dgb, [x0] ld1 {dgav.4s, dgbv.4s}, [x0]
/* load sha256_ce_state::finalize */ /* load sha256_ce_state::finalize */
ldr w4, [x0, #:lo12:sha256_ce_offsetof_finalize] ldr w4, [x0, #:lo12:sha256_ce_offsetof_finalize]
...@@ -148,6 +148,6 @@ CPU_LE( rev32 v19.16b, v19.16b ) ...@@ -148,6 +148,6 @@ CPU_LE( rev32 v19.16b, v19.16b )
b 1b b 1b
/* store new state */ /* store new state */
3: stp dga, dgb, [x0] 3: st1 {dgav.4s, dgbv.4s}, [x0]
ret ret
ENDPROC(sha2_ce_transform) ENDPROC(sha2_ce_transform)
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment