Commit 17a4ed55 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Dmitry Torokhov

Input: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Warning level 2 was used: -Wimplicit-fallthrough=2
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 6cad4e26
...@@ -259,6 +259,7 @@ static unsigned char db9_saturn_read_packet(struct parport *port, unsigned char ...@@ -259,6 +259,7 @@ static unsigned char db9_saturn_read_packet(struct parport *port, unsigned char
db9_saturn_write_sub(port, type, 3, powered, 0); db9_saturn_write_sub(port, type, 3, powered, 0);
return data[0] = 0xe3; return data[0] = 0xe3;
} }
/* else: fall through */
default: default:
return data[0]; return data[0];
} }
...@@ -278,11 +279,14 @@ static int db9_saturn_report(unsigned char id, unsigned char data[60], struct in ...@@ -278,11 +279,14 @@ static int db9_saturn_report(unsigned char id, unsigned char data[60], struct in
switch (data[j]) { switch (data[j]) {
case 0x16: /* multi controller (analog 4 axis) */ case 0x16: /* multi controller (analog 4 axis) */
input_report_abs(dev, db9_abs[5], data[j + 6]); input_report_abs(dev, db9_abs[5], data[j + 6]);
/* fall through */
case 0x15: /* mission stick (analog 3 axis) */ case 0x15: /* mission stick (analog 3 axis) */
input_report_abs(dev, db9_abs[3], data[j + 4]); input_report_abs(dev, db9_abs[3], data[j + 4]);
input_report_abs(dev, db9_abs[4], data[j + 5]); input_report_abs(dev, db9_abs[4], data[j + 5]);
/* fall through */
case 0x13: /* racing controller (analog 1 axis) */ case 0x13: /* racing controller (analog 1 axis) */
input_report_abs(dev, db9_abs[2], data[j + 3]); input_report_abs(dev, db9_abs[2], data[j + 3]);
/* fall through */
case 0x34: /* saturn keyboard (udlr ZXC ASD QE Esc) */ case 0x34: /* saturn keyboard (udlr ZXC ASD QE Esc) */
case 0x02: /* digital pad (digital 2 axis + buttons) */ case 0x02: /* digital pad (digital 2 axis + buttons) */
input_report_abs(dev, db9_abs[0], !(data[j + 1] & 128) - !(data[j + 1] & 64)); input_report_abs(dev, db9_abs[0], !(data[j + 1] & 128) - !(data[j + 1] & 64));
...@@ -376,6 +380,7 @@ static void db9_timer(struct timer_list *t) ...@@ -376,6 +380,7 @@ static void db9_timer(struct timer_list *t)
input_report_abs(dev2, ABS_X, (data & DB9_RIGHT ? 0 : 1) - (data & DB9_LEFT ? 0 : 1)); input_report_abs(dev2, ABS_X, (data & DB9_RIGHT ? 0 : 1) - (data & DB9_LEFT ? 0 : 1));
input_report_abs(dev2, ABS_Y, (data & DB9_DOWN ? 0 : 1) - (data & DB9_UP ? 0 : 1)); input_report_abs(dev2, ABS_Y, (data & DB9_DOWN ? 0 : 1) - (data & DB9_UP ? 0 : 1));
input_report_key(dev2, BTN_TRIGGER, ~data & DB9_FIRE1); input_report_key(dev2, BTN_TRIGGER, ~data & DB9_FIRE1);
/* fall through */
case DB9_MULTI_0802: case DB9_MULTI_0802:
......
...@@ -885,6 +885,7 @@ static int adp5589_probe(struct i2c_client *client, ...@@ -885,6 +885,7 @@ static int adp5589_probe(struct i2c_client *client,
switch (id->driver_data) { switch (id->driver_data) {
case ADP5585_02: case ADP5585_02:
kpad->support_row5 = true; kpad->support_row5 = true;
/* fall through */
case ADP5585_01: case ADP5585_01:
kpad->is_adp5585 = true; kpad->is_adp5585 = true;
kpad->var = &const_adp5585; kpad->var = &const_adp5585;
......
...@@ -472,6 +472,7 @@ static int atp_status_check(struct urb *urb) ...@@ -472,6 +472,7 @@ static int atp_status_check(struct urb *urb)
dev->info->datalen, dev->urb->actual_length); dev->info->datalen, dev->urb->actual_length);
dev->overflow_warned = true; dev->overflow_warned = true;
} }
/* fall through */
case -ECONNRESET: case -ECONNRESET:
case -ENOENT: case -ENOENT:
case -ESHUTDOWN: case -ESHUTDOWN:
......
...@@ -2554,6 +2554,7 @@ static int cyapa_gen5_do_operational_check(struct cyapa *cyapa) ...@@ -2554,6 +2554,7 @@ static int cyapa_gen5_do_operational_check(struct cyapa *cyapa)
} }
cyapa->state = CYAPA_STATE_GEN5_APP; cyapa->state = CYAPA_STATE_GEN5_APP;
/* fall through */
case CYAPA_STATE_GEN5_APP: case CYAPA_STATE_GEN5_APP:
/* /*
......
...@@ -680,6 +680,7 @@ static int cyapa_gen6_operational_check(struct cyapa *cyapa) ...@@ -680,6 +680,7 @@ static int cyapa_gen6_operational_check(struct cyapa *cyapa)
} }
cyapa->state = CYAPA_STATE_GEN6_APP; cyapa->state = CYAPA_STATE_GEN6_APP;
/* fall through */
case CYAPA_STATE_GEN6_APP: case CYAPA_STATE_GEN6_APP:
/* /*
......
...@@ -340,7 +340,7 @@ static void elantech_report_absolute_v2(struct psmouse *psmouse) ...@@ -340,7 +340,7 @@ static void elantech_report_absolute_v2(struct psmouse *psmouse)
*/ */
if (packet[3] & 0x80) if (packet[3] & 0x80)
fingers = 4; fingers = 4;
/* pass through... */ /* fall through */
case 1: case 1:
/* /*
* byte 1: . . . . x11 x10 x9 x8 * byte 1: . . . . x11 x10 x9 x8
......
...@@ -139,7 +139,8 @@ static void sermouse_process_ms(struct sermouse *sermouse, signed char data) ...@@ -139,7 +139,8 @@ static void sermouse_process_ms(struct sermouse *sermouse, signed char data)
switch (sermouse->type) { switch (sermouse->type) {
case SERIO_MS: case SERIO_MS:
sermouse->type = SERIO_MP; sermouse->type = SERIO_MP;
/* fall through */
case SERIO_MP: case SERIO_MP:
if ((data >> 2) & 3) break; /* M++ Wireless Extension packet. */ if ((data >> 2) & 3) break; /* M++ Wireless Extension packet. */
...@@ -150,6 +151,7 @@ static void sermouse_process_ms(struct sermouse *sermouse, signed char data) ...@@ -150,6 +151,7 @@ static void sermouse_process_ms(struct sermouse *sermouse, signed char data)
case SERIO_MZP: case SERIO_MZP:
case SERIO_MZPP: case SERIO_MZPP:
input_report_key(dev, BTN_SIDE, (data >> 5) & 1); input_report_key(dev, BTN_SIDE, (data >> 5) & 1);
/* fall through */
case SERIO_MZ: case SERIO_MZ:
input_report_key(dev, BTN_MIDDLE, (data >> 4) & 1); input_report_key(dev, BTN_MIDDLE, (data >> 4) & 1);
......
...@@ -352,6 +352,7 @@ static int elo_connect(struct serio *serio, struct serio_driver *drv) ...@@ -352,6 +352,7 @@ static int elo_connect(struct serio *serio, struct serio_driver *drv)
case 1: /* 6-byte protocol */ case 1: /* 6-byte protocol */
input_set_abs_params(input_dev, ABS_PRESSURE, 0, 15, 0, 0); input_set_abs_params(input_dev, ABS_PRESSURE, 0, 15, 0, 0);
/* fall through */
case 2: /* 4-byte protocol */ case 2: /* 4-byte protocol */
input_set_abs_params(input_dev, ABS_X, 96, 4000, 0, 0); input_set_abs_params(input_dev, ABS_X, 96, 4000, 0, 0);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment