Commit 17c048fc authored by Josef Gajdusek's avatar Josef Gajdusek Committed by Guenter Roeck

hwmon: (emc1403) fix inverted store_hyst()

Attempts to set the hysteresis value to a temperature below the target
limit fails with "write error: Numerical result out of range" due to
an inverted comparison.
Signed-off-by: default avatarJosef Gajdusek <atx@atx.name>
Reviewed-by: default avatarJean Delvare <jdelvare@suse.de>
Cc: stable@vger.kernel.org
[Guenter Roeck: Updated headline and description]
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent d6d211db
...@@ -163,7 +163,7 @@ static ssize_t store_hyst(struct device *dev, ...@@ -163,7 +163,7 @@ static ssize_t store_hyst(struct device *dev,
if (retval < 0) if (retval < 0)
goto fail; goto fail;
hyst = val - retval * 1000; hyst = retval * 1000 - val;
hyst = DIV_ROUND_CLOSEST(hyst, 1000); hyst = DIV_ROUND_CLOSEST(hyst, 1000);
if (hyst < 0 || hyst > 255) { if (hyst < 0 || hyst > 255) {
retval = -ERANGE; retval = -ERANGE;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment