Commit 1855256c authored by Jeff Garzik's avatar Jeff Garzik

drivers/firmware: const-ify DMI API and internals

Three main sets of changes:

1) dmi_get_system_info() return value should have been marked const,
   since callers should not be changing that data.

2) const-ify DMI internals, since DMI firmware tables should,
   whenever possible, be marked const to ensure we never ever write to
   that data area.

3) const-ify DMI API, to enable marking tables const where possible
   in low-level drivers.

And if we're really lucky, this might enable some additional
optimizations on the part of the compiler.

The bulk of the changes are #2 and #3, which are interrelated.  #1 could
have been a separate patch, but it was so small compared to the others,
it was easier to roll it into this changeset.
Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
parent bbf25010
...@@ -907,7 +907,7 @@ static void __init acpi_process_madt(void) ...@@ -907,7 +907,7 @@ static void __init acpi_process_madt(void)
#ifdef __i386__ #ifdef __i386__
static int __init disable_acpi_irq(struct dmi_system_id *d) static int __init disable_acpi_irq(const struct dmi_system_id *d)
{ {
if (!acpi_force) { if (!acpi_force) {
printk(KERN_NOTICE "%s detected: force use of acpi=noirq\n", printk(KERN_NOTICE "%s detected: force use of acpi=noirq\n",
...@@ -917,7 +917,7 @@ static int __init disable_acpi_irq(struct dmi_system_id *d) ...@@ -917,7 +917,7 @@ static int __init disable_acpi_irq(struct dmi_system_id *d)
return 0; return 0;
} }
static int __init disable_acpi_pci(struct dmi_system_id *d) static int __init disable_acpi_pci(const struct dmi_system_id *d)
{ {
if (!acpi_force) { if (!acpi_force) {
printk(KERN_NOTICE "%s detected: force use of pci=noacpi\n", printk(KERN_NOTICE "%s detected: force use of pci=noacpi\n",
...@@ -927,7 +927,7 @@ static int __init disable_acpi_pci(struct dmi_system_id *d) ...@@ -927,7 +927,7 @@ static int __init disable_acpi_pci(struct dmi_system_id *d)
return 0; return 0;
} }
static int __init dmi_disable_acpi(struct dmi_system_id *d) static int __init dmi_disable_acpi(const struct dmi_system_id *d)
{ {
if (!acpi_force) { if (!acpi_force) {
printk(KERN_NOTICE "%s detected: acpi off\n", d->ident); printk(KERN_NOTICE "%s detected: acpi off\n", d->ident);
...@@ -942,7 +942,7 @@ static int __init dmi_disable_acpi(struct dmi_system_id *d) ...@@ -942,7 +942,7 @@ static int __init dmi_disable_acpi(struct dmi_system_id *d)
/* /*
* Limit ACPI to CPU enumeration for HT * Limit ACPI to CPU enumeration for HT
*/ */
static int __init force_acpi_ht(struct dmi_system_id *d) static int __init force_acpi_ht(const struct dmi_system_id *d)
{ {
if (!acpi_force) { if (!acpi_force) {
printk(KERN_NOTICE "%s detected: force use of acpi=ht\n", printk(KERN_NOTICE "%s detected: force use of acpi=ht\n",
......
...@@ -84,7 +84,7 @@ __setup("acpi_sleep=", acpi_sleep_setup); ...@@ -84,7 +84,7 @@ __setup("acpi_sleep=", acpi_sleep_setup);
/* Ouch, we want to delete this. We already have better version in userspace, in /* Ouch, we want to delete this. We already have better version in userspace, in
s2ram from suspend.sf.net project */ s2ram from suspend.sf.net project */
static __init int reset_videomode_after_s3(struct dmi_system_id *d) static __init int reset_videomode_after_s3(const struct dmi_system_id *d)
{ {
acpi_realmode_flags |= 2; acpi_realmode_flags |= 2;
return 0; return 0;
......
...@@ -1869,7 +1869,7 @@ static struct miscdevice apm_device = { ...@@ -1869,7 +1869,7 @@ static struct miscdevice apm_device = {
/* Simple "print if true" callback */ /* Simple "print if true" callback */
static int __init print_if_true(struct dmi_system_id *d) static int __init print_if_true(const struct dmi_system_id *d)
{ {
printk("%s\n", d->ident); printk("%s\n", d->ident);
return 0; return 0;
...@@ -1879,14 +1879,14 @@ static int __init print_if_true(struct dmi_system_id *d) ...@@ -1879,14 +1879,14 @@ static int __init print_if_true(struct dmi_system_id *d)
* Some Bioses enable the PS/2 mouse (touchpad) at resume, even if it was * Some Bioses enable the PS/2 mouse (touchpad) at resume, even if it was
* disabled before the suspend. Linux used to get terribly confused by that. * disabled before the suspend. Linux used to get terribly confused by that.
*/ */
static int __init broken_ps2_resume(struct dmi_system_id *d) static int __init broken_ps2_resume(const struct dmi_system_id *d)
{ {
printk(KERN_INFO "%s machine detected. Mousepad Resume Bug workaround hopefully not needed.\n", d->ident); printk(KERN_INFO "%s machine detected. Mousepad Resume Bug workaround hopefully not needed.\n", d->ident);
return 0; return 0;
} }
/* Some bioses have a broken protected mode poweroff and need to use realmode */ /* Some bioses have a broken protected mode poweroff and need to use realmode */
static int __init set_realmode_power_off(struct dmi_system_id *d) static int __init set_realmode_power_off(const struct dmi_system_id *d)
{ {
if (apm_info.realmode_power_off == 0) { if (apm_info.realmode_power_off == 0) {
apm_info.realmode_power_off = 1; apm_info.realmode_power_off = 1;
...@@ -1896,7 +1896,7 @@ static int __init set_realmode_power_off(struct dmi_system_id *d) ...@@ -1896,7 +1896,7 @@ static int __init set_realmode_power_off(struct dmi_system_id *d)
} }
/* Some laptops require interrupts to be enabled during APM calls */ /* Some laptops require interrupts to be enabled during APM calls */
static int __init set_apm_ints(struct dmi_system_id *d) static int __init set_apm_ints(const struct dmi_system_id *d)
{ {
if (apm_info.allow_ints == 0) { if (apm_info.allow_ints == 0) {
apm_info.allow_ints = 1; apm_info.allow_ints = 1;
...@@ -1906,7 +1906,7 @@ static int __init set_apm_ints(struct dmi_system_id *d) ...@@ -1906,7 +1906,7 @@ static int __init set_apm_ints(struct dmi_system_id *d)
} }
/* Some APM bioses corrupt memory or just plain do not work */ /* Some APM bioses corrupt memory or just plain do not work */
static int __init apm_is_horked(struct dmi_system_id *d) static int __init apm_is_horked(const struct dmi_system_id *d)
{ {
if (apm_info.disabled == 0) { if (apm_info.disabled == 0) {
apm_info.disabled = 1; apm_info.disabled = 1;
...@@ -1915,7 +1915,7 @@ static int __init apm_is_horked(struct dmi_system_id *d) ...@@ -1915,7 +1915,7 @@ static int __init apm_is_horked(struct dmi_system_id *d)
return 0; return 0;
} }
static int __init apm_is_horked_d850md(struct dmi_system_id *d) static int __init apm_is_horked_d850md(const struct dmi_system_id *d)
{ {
if (apm_info.disabled == 0) { if (apm_info.disabled == 0) {
apm_info.disabled = 1; apm_info.disabled = 1;
...@@ -1927,7 +1927,7 @@ static int __init apm_is_horked_d850md(struct dmi_system_id *d) ...@@ -1927,7 +1927,7 @@ static int __init apm_is_horked_d850md(struct dmi_system_id *d)
} }
/* Some APM bioses hang on APM idle calls */ /* Some APM bioses hang on APM idle calls */
static int __init apm_likes_to_melt(struct dmi_system_id *d) static int __init apm_likes_to_melt(const struct dmi_system_id *d)
{ {
if (apm_info.forbid_idle == 0) { if (apm_info.forbid_idle == 0) {
apm_info.forbid_idle = 1; apm_info.forbid_idle = 1;
...@@ -1951,7 +1951,7 @@ static int __init apm_likes_to_melt(struct dmi_system_id *d) ...@@ -1951,7 +1951,7 @@ static int __init apm_likes_to_melt(struct dmi_system_id *d)
* Phoenix A04 08/24/2000 is known bad (Dell Inspiron 5000e) * Phoenix A04 08/24/2000 is known bad (Dell Inspiron 5000e)
* Phoenix A07 09/29/2000 is known good (Dell Inspiron 5000) * Phoenix A07 09/29/2000 is known good (Dell Inspiron 5000)
*/ */
static int __init broken_apm_power(struct dmi_system_id *d) static int __init broken_apm_power(const struct dmi_system_id *d)
{ {
apm_info.get_power_status_broken = 1; apm_info.get_power_status_broken = 1;
printk(KERN_WARNING "BIOS strings suggest APM bugs, disabling power status reporting.\n"); printk(KERN_WARNING "BIOS strings suggest APM bugs, disabling power status reporting.\n");
...@@ -1962,7 +1962,7 @@ static int __init broken_apm_power(struct dmi_system_id *d) ...@@ -1962,7 +1962,7 @@ static int __init broken_apm_power(struct dmi_system_id *d)
* This bios swaps the APM minute reporting bytes over (Many sony laptops * This bios swaps the APM minute reporting bytes over (Many sony laptops
* have this problem). * have this problem).
*/ */
static int __init swab_apm_power_in_minutes(struct dmi_system_id *d) static int __init swab_apm_power_in_minutes(const struct dmi_system_id *d)
{ {
apm_info.get_power_status_swabinminutes = 1; apm_info.get_power_status_swabinminutes = 1;
printk(KERN_WARNING "BIOS strings suggest APM reports battery life in minutes and wrong byte order.\n"); printk(KERN_WARNING "BIOS strings suggest APM reports battery life in minutes and wrong byte order.\n");
......
...@@ -533,13 +533,13 @@ static int __init acpi_cpufreq_early_init(void) ...@@ -533,13 +533,13 @@ static int __init acpi_cpufreq_early_init(void)
*/ */
static int bios_with_sw_any_bug; static int bios_with_sw_any_bug;
static int sw_any_bug_found(struct dmi_system_id *d) static int sw_any_bug_found(const struct dmi_system_id *d)
{ {
bios_with_sw_any_bug = 1; bios_with_sw_any_bug = 1;
return 0; return 0;
} }
static struct dmi_system_id sw_any_bug_dmi_table[] = { static const struct dmi_system_id sw_any_bug_dmi_table[] = {
{ {
.callback = sw_any_bug_found, .callback = sw_any_bug_found,
.ident = "Supermicro Server X6DLP", .ident = "Supermicro Server X6DLP",
......
...@@ -79,7 +79,7 @@ __setup("reboot=", reboot_setup); ...@@ -79,7 +79,7 @@ __setup("reboot=", reboot_setup);
/* /*
* Some machines require the "reboot=b" commandline option, this quirk makes that automatic. * Some machines require the "reboot=b" commandline option, this quirk makes that automatic.
*/ */
static int __init set_bios_reboot(struct dmi_system_id *d) static int __init set_bios_reboot(const struct dmi_system_id *d)
{ {
if (!reboot_thru_bios) { if (!reboot_thru_bios) {
reboot_thru_bios = 1; reboot_thru_bios = 1;
......
...@@ -305,7 +305,7 @@ void mark_tsc_unstable(char *reason) ...@@ -305,7 +305,7 @@ void mark_tsc_unstable(char *reason)
} }
EXPORT_SYMBOL_GPL(mark_tsc_unstable); EXPORT_SYMBOL_GPL(mark_tsc_unstable);
static int __init dmi_mark_tsc_unstable(struct dmi_system_id *d) static int __init dmi_mark_tsc_unstable(const struct dmi_system_id *d)
{ {
printk(KERN_NOTICE "%s detected: marking TSC unstable.\n", printk(KERN_NOTICE "%s detected: marking TSC unstable.\n",
d->ident); d->ident);
......
...@@ -21,7 +21,7 @@ ...@@ -21,7 +21,7 @@
static int dmi_bigsmp; /* can be set by dmi scanners */ static int dmi_bigsmp; /* can be set by dmi scanners */
static int hp_ht_bigsmp(struct dmi_system_id *d) static int hp_ht_bigsmp(const struct dmi_system_id *d)
{ {
#ifdef CONFIG_X86_GENERICARCH #ifdef CONFIG_X86_GENERICARCH
printk(KERN_NOTICE "%s detected: force use of apic=bigsmp\n", d->ident); printk(KERN_NOTICE "%s detected: force use of apic=bigsmp\n", d->ident);
...@@ -31,7 +31,7 @@ static int hp_ht_bigsmp(struct dmi_system_id *d) ...@@ -31,7 +31,7 @@ static int hp_ht_bigsmp(struct dmi_system_id *d)
} }
static struct dmi_system_id bigsmp_dmi_table[] = { static const struct dmi_system_id bigsmp_dmi_table[] = {
{ hp_ht_bigsmp, "HP ProLiant DL760 G2", { { hp_ht_bigsmp, "HP ProLiant DL760 G2", {
DMI_MATCH(DMI_BIOS_VENDOR, "HP"), DMI_MATCH(DMI_BIOS_VENDOR, "HP"),
DMI_MATCH(DMI_BIOS_VERSION, "P44-"), DMI_MATCH(DMI_BIOS_VERSION, "P44-"),
......
...@@ -123,7 +123,7 @@ void __devinit pcibios_fixup_bus(struct pci_bus *b) ...@@ -123,7 +123,7 @@ void __devinit pcibios_fixup_bus(struct pci_bus *b)
* on the kernel command line (which was parsed earlier). * on the kernel command line (which was parsed earlier).
*/ */
static int __devinit set_bf_sort(struct dmi_system_id *d) static int __devinit set_bf_sort(const struct dmi_system_id *d)
{ {
if (pci_bf_sort == pci_bf_sort_default) { if (pci_bf_sort == pci_bf_sort_default) {
pci_bf_sort = pci_dmi_bf; pci_bf_sort = pci_dmi_bf;
...@@ -136,7 +136,7 @@ static int __devinit set_bf_sort(struct dmi_system_id *d) ...@@ -136,7 +136,7 @@ static int __devinit set_bf_sort(struct dmi_system_id *d)
* Enable renumbering of PCI bus# ranges to reach all PCI busses (Cardbus) * Enable renumbering of PCI bus# ranges to reach all PCI busses (Cardbus)
*/ */
#ifdef __i386__ #ifdef __i386__
static int __devinit assign_all_busses(struct dmi_system_id *d) static int __devinit assign_all_busses(const struct dmi_system_id *d)
{ {
pci_probe |= PCI_ASSIGN_ALL_BUSSES; pci_probe |= PCI_ASSIGN_ALL_BUSSES;
printk(KERN_INFO "%s detected: enabling PCI bus# renumbering" printk(KERN_INFO "%s detected: enabling PCI bus# renumbering"
......
...@@ -1010,7 +1010,7 @@ static void __init pcibios_fixup_irqs(void) ...@@ -1010,7 +1010,7 @@ static void __init pcibios_fixup_irqs(void)
* Work around broken HP Pavilion Notebooks which assign USB to * Work around broken HP Pavilion Notebooks which assign USB to
* IRQ 9 even though it is actually wired to IRQ 11 * IRQ 9 even though it is actually wired to IRQ 11
*/ */
static int __init fix_broken_hp_bios_irq9(struct dmi_system_id *d) static int __init fix_broken_hp_bios_irq9(const struct dmi_system_id *d)
{ {
if (!broken_hp_bios_irq9) { if (!broken_hp_bios_irq9) {
broken_hp_bios_irq9 = 1; broken_hp_bios_irq9 = 1;
...@@ -1023,7 +1023,7 @@ static int __init fix_broken_hp_bios_irq9(struct dmi_system_id *d) ...@@ -1023,7 +1023,7 @@ static int __init fix_broken_hp_bios_irq9(struct dmi_system_id *d)
* Work around broken Acer TravelMate 360 Notebooks which assign * Work around broken Acer TravelMate 360 Notebooks which assign
* Cardbus to IRQ 11 even though it is actually wired to IRQ 10 * Cardbus to IRQ 11 even though it is actually wired to IRQ 10
*/ */
static int __init fix_acer_tm360_irqrouting(struct dmi_system_id *d) static int __init fix_acer_tm360_irqrouting(const struct dmi_system_id *d)
{ {
if (!acer_tm360_irqrouting) { if (!acer_tm360_irqrouting) {
acer_tm360_irqrouting = 1; acer_tm360_irqrouting = 1;
......
...@@ -1214,7 +1214,7 @@ acpi_os_validate_address ( ...@@ -1214,7 +1214,7 @@ acpi_os_validate_address (
} }
#ifdef CONFIG_DMI #ifdef CONFIG_DMI
static int dmi_osi_linux(struct dmi_system_id *d) static int dmi_osi_linux(const struct dmi_system_id *d)
{ {
printk(KERN_NOTICE "%s detected: enabling _OSI(Linux)\n", d->ident); printk(KERN_NOTICE "%s detected: enabling _OSI(Linux)\n", d->ident);
enable_osi_linux(1); enable_osi_linux(1);
......
...@@ -92,7 +92,7 @@ module_param(bm_history, uint, 0644); ...@@ -92,7 +92,7 @@ module_param(bm_history, uint, 0644);
* *
* To skip this limit, boot/load with a large max_cstate limit. * To skip this limit, boot/load with a large max_cstate limit.
*/ */
static int set_max_cstate(struct dmi_system_id *id) static int set_max_cstate(const struct dmi_system_id *id)
{ {
if (max_cstate > ACPI_PROCESSOR_MAX_POWER) if (max_cstate > ACPI_PROCESSOR_MAX_POWER)
return 0; return 0;
......
...@@ -215,7 +215,7 @@ static struct pm_ops acpi_pm_ops = { ...@@ -215,7 +215,7 @@ static struct pm_ops acpi_pm_ops = {
* Toshiba fails to preserve interrupts over S1, reinitialization * Toshiba fails to preserve interrupts over S1, reinitialization
* of 8259 is needed after S1 resume. * of 8259 is needed after S1 resume.
*/ */
static int __init init_ints_after_s1(struct dmi_system_id *d) static int __init init_ints_after_s1(const struct dmi_system_id *d)
{ {
printk(KERN_WARNING "%s with broken S1 detected.\n", d->ident); printk(KERN_WARNING "%s with broken S1 detected.\n", d->ident);
init_8259A_after_S1 = 1; init_8259A_after_S1 = 1;
......
...@@ -1360,7 +1360,7 @@ static int acpi_thermal_resume(struct acpi_device *device) ...@@ -1360,7 +1360,7 @@ static int acpi_thermal_resume(struct acpi_device *device)
} }
#ifdef CONFIG_DMI #ifdef CONFIG_DMI
static int thermal_act(struct dmi_system_id *d) { static int thermal_act(const struct dmi_system_id *d) {
if (act == 0) { if (act == 0) {
printk(KERN_NOTICE "ACPI: %s detected: " printk(KERN_NOTICE "ACPI: %s detected: "
...@@ -1369,14 +1369,14 @@ static int thermal_act(struct dmi_system_id *d) { ...@@ -1369,14 +1369,14 @@ static int thermal_act(struct dmi_system_id *d) {
} }
return 0; return 0;
} }
static int thermal_nocrt(struct dmi_system_id *d) { static int thermal_nocrt(const struct dmi_system_id *d) {
printk(KERN_NOTICE "ACPI: %s detected: " printk(KERN_NOTICE "ACPI: %s detected: "
"disabling all critical thermal trip point actions.\n", d->ident); "disabling all critical thermal trip point actions.\n", d->ident);
nocrt = 1; nocrt = 1;
return 0; return 0;
} }
static int thermal_tzp(struct dmi_system_id *d) { static int thermal_tzp(const struct dmi_system_id *d) {
if (tzp == 0) { if (tzp == 0) {
printk(KERN_NOTICE "ACPI: %s detected: " printk(KERN_NOTICE "ACPI: %s detected: "
...@@ -1385,7 +1385,7 @@ static int thermal_tzp(struct dmi_system_id *d) { ...@@ -1385,7 +1385,7 @@ static int thermal_tzp(struct dmi_system_id *d) {
} }
return 0; return 0;
} }
static int thermal_psv(struct dmi_system_id *d) { static int thermal_psv(const struct dmi_system_id *d) {
if (psv == 0) { if (psv == 0) {
printk(KERN_NOTICE "ACPI: %s detected: " printk(KERN_NOTICE "ACPI: %s detected: "
......
...@@ -919,7 +919,7 @@ static void ich_set_dmamode (struct ata_port *ap, struct ata_device *adev) ...@@ -919,7 +919,7 @@ static void ich_set_dmamode (struct ata_port *ap, struct ata_device *adev)
#ifdef CONFIG_PM #ifdef CONFIG_PM
static int piix_broken_suspend(void) static int piix_broken_suspend(void)
{ {
static struct dmi_system_id sysids[] = { static const struct dmi_system_id sysids[] = {
{ {
.ident = "TECRA M3", .ident = "TECRA M3",
.matches = { .matches = {
...@@ -1183,7 +1183,7 @@ static void __devinit piix_init_sata_map(struct pci_dev *pdev, ...@@ -1183,7 +1183,7 @@ static void __devinit piix_init_sata_map(struct pci_dev *pdev,
static void piix_iocfg_bit18_quirk(struct pci_dev *pdev) static void piix_iocfg_bit18_quirk(struct pci_dev *pdev)
{ {
static struct dmi_system_id sysids[] = { static const struct dmi_system_id sysids[] = {
{ {
/* Clevo M570U sets IOCFG bit 18 if the cdrom /* Clevo M570U sets IOCFG bit 18 if the cdrom
* isn't used to boot the system which * isn't used to boot the system which
......
...@@ -40,7 +40,7 @@ ...@@ -40,7 +40,7 @@
* Cable special cases * Cable special cases
*/ */
static struct dmi_system_id cable_dmi_table[] = { static const struct dmi_system_id cable_dmi_table[] = {
{ {
.ident = "HP Pavilion N5430", .ident = "HP Pavilion N5430",
.matches = { .matches = {
......
...@@ -214,7 +214,7 @@ static struct ata_port_operations cs5530_port_ops = { ...@@ -214,7 +214,7 @@ static struct ata_port_operations cs5530_port_ops = {
.port_start = ata_port_start, .port_start = ata_port_start,
}; };
static struct dmi_system_id palmax_dmi_table[] = { static const struct dmi_system_id palmax_dmi_table[] = {
{ {
.ident = "Palmax PD1100", .ident = "Palmax PD1100",
.matches = { .matches = {
......
...@@ -129,7 +129,7 @@ static const struct via_isa_bridge { ...@@ -129,7 +129,7 @@ static const struct via_isa_bridge {
* Cable special cases * Cable special cases
*/ */
static struct dmi_system_id cable_dmi_table[] = { static const struct dmi_system_id cable_dmi_table[] = {
{ {
.ident = "Acer Ferrari 3400", .ident = "Acer Ferrari 3400",
.matches = { .matches = {
......
...@@ -98,9 +98,9 @@ struct smm_regs { ...@@ -98,9 +98,9 @@ struct smm_regs {
unsigned int edi __attribute__ ((packed)); unsigned int edi __attribute__ ((packed));
}; };
static inline char *i8k_get_dmi_data(int field) static inline const char *i8k_get_dmi_data(int field)
{ {
char *dmi_data = dmi_get_system_info(field); const char *dmi_data = dmi_get_system_info(field);
return dmi_data && *dmi_data ? dmi_data : "?"; return dmi_data && *dmi_data ? dmi_data : "?";
} }
......
...@@ -1965,10 +1965,10 @@ struct dmi_ipmi_data ...@@ -1965,10 +1965,10 @@ struct dmi_ipmi_data
u8 slave_addr; u8 slave_addr;
}; };
static int __devinit decode_dmi(struct dmi_header *dm, static int __devinit decode_dmi(const struct dmi_header *dm,
struct dmi_ipmi_data *dmi) struct dmi_ipmi_data *dmi)
{ {
u8 *data = (u8 *)dm; const u8 *data = (const u8 *)dm;
unsigned long base_addr; unsigned long base_addr;
u8 reg_spacing; u8 reg_spacing;
u8 len = dm->length; u8 len = dm->length;
...@@ -2091,13 +2091,14 @@ static __devinit void try_init_dmi(struct dmi_ipmi_data *ipmi_data) ...@@ -2091,13 +2091,14 @@ static __devinit void try_init_dmi(struct dmi_ipmi_data *ipmi_data)
static void __devinit dmi_find_bmc(void) static void __devinit dmi_find_bmc(void)
{ {
struct dmi_device *dev = NULL; const struct dmi_device *dev = NULL;
struct dmi_ipmi_data data; struct dmi_ipmi_data data;
int rv; int rv;
while ((dev = dmi_find_device(DMI_DEV_TYPE_IPMI, NULL, dev))) { while ((dev = dmi_find_device(DMI_DEV_TYPE_IPMI, NULL, dev))) {
memset(&data, 0, sizeof(data)); memset(&data, 0, sizeof(data));
rv = decode_dmi((struct dmi_header *) dev->device_data, &data); rv = decode_dmi((const struct dmi_header *) dev->device_data,
&data);
if (!rv) if (!rv)
try_init_dmi(&data); try_init_dmi(&data);
} }
......
...@@ -8,9 +8,9 @@ ...@@ -8,9 +8,9 @@
#include <linux/slab.h> #include <linux/slab.h>
#include <asm/dmi.h> #include <asm/dmi.h>
static char * __init dmi_string(struct dmi_header *dm, u8 s) static char * __init dmi_string(const struct dmi_header *dm, u8 s)
{ {
u8 *bp = ((u8 *) dm) + dm->length; const u8 *bp = ((u8 *) dm) + dm->length;
char *str = ""; char *str = "";
if (s) { if (s) {
...@@ -37,7 +37,7 @@ static char * __init dmi_string(struct dmi_header *dm, u8 s) ...@@ -37,7 +37,7 @@ static char * __init dmi_string(struct dmi_header *dm, u8 s)
* pointing to completely the wrong place for example * pointing to completely the wrong place for example
*/ */
static int __init dmi_table(u32 base, int len, int num, static int __init dmi_table(u32 base, int len, int num,
void (*decode)(struct dmi_header *)) void (*decode)(const struct dmi_header *))
{ {
u8 *buf, *data; u8 *buf, *data;
int i = 0; int i = 0;
...@@ -53,7 +53,8 @@ static int __init dmi_table(u32 base, int len, int num, ...@@ -53,7 +53,8 @@ static int __init dmi_table(u32 base, int len, int num,
* OR we run off the end of the table (also happens) * OR we run off the end of the table (also happens)
*/ */
while ((i < num) && (data - buf + sizeof(struct dmi_header)) <= len) { while ((i < num) && (data - buf + sizeof(struct dmi_header)) <= len) {
struct dmi_header *dm = (struct dmi_header *)data; const struct dmi_header *dm = (const struct dmi_header *)data;
/* /*
* We want to know the total length (formated area and strings) * We want to know the total length (formated area and strings)
* before decoding to make sure we won't run off the table in * before decoding to make sure we won't run off the table in
...@@ -71,7 +72,7 @@ static int __init dmi_table(u32 base, int len, int num, ...@@ -71,7 +72,7 @@ static int __init dmi_table(u32 base, int len, int num,
return 0; return 0;
} }
static int __init dmi_checksum(u8 *buf) static int __init dmi_checksum(const u8 *buf)
{ {
u8 sum = 0; u8 sum = 0;
int a; int a;
...@@ -89,9 +90,10 @@ int dmi_available; ...@@ -89,9 +90,10 @@ int dmi_available;
/* /*
* Save a DMI string * Save a DMI string
*/ */
static void __init dmi_save_ident(struct dmi_header *dm, int slot, int string) static void __init dmi_save_ident(const struct dmi_header *dm, int slot, int string)
{ {
char *p, *d = (char*) dm; const char *d = (const char*) dm;
char *p;
if (dmi_ident[slot]) if (dmi_ident[slot])
return; return;
...@@ -103,9 +105,9 @@ static void __init dmi_save_ident(struct dmi_header *dm, int slot, int string) ...@@ -103,9 +105,9 @@ static void __init dmi_save_ident(struct dmi_header *dm, int slot, int string)
dmi_ident[slot] = p; dmi_ident[slot] = p;
} }
static void __init dmi_save_uuid(struct dmi_header *dm, int slot, int index) static void __init dmi_save_uuid(const struct dmi_header *dm, int slot, int index)
{ {
u8 *d = (u8*) dm + index; const u8 *d = (u8*) dm + index;
char *s; char *s;
int is_ff = 1, is_00 = 1, i; int is_ff = 1, is_00 = 1, i;
...@@ -132,9 +134,9 @@ static void __init dmi_save_uuid(struct dmi_header *dm, int slot, int index) ...@@ -132,9 +134,9 @@ static void __init dmi_save_uuid(struct dmi_header *dm, int slot, int index)
dmi_ident[slot] = s; dmi_ident[slot] = s;
} }
static void __init dmi_save_type(struct dmi_header *dm, int slot, int index) static void __init dmi_save_type(const struct dmi_header *dm, int slot, int index)
{ {
u8 *d = (u8*) dm + index; const u8 *d = (u8*) dm + index;
char *s; char *s;
if (dmi_ident[slot]) if (dmi_ident[slot])
...@@ -148,13 +150,13 @@ static void __init dmi_save_type(struct dmi_header *dm, int slot, int index) ...@@ -148,13 +150,13 @@ static void __init dmi_save_type(struct dmi_header *dm, int slot, int index)
dmi_ident[slot] = s; dmi_ident[slot] = s;
} }
static void __init dmi_save_devices(struct dmi_header *dm) static void __init dmi_save_devices(const struct dmi_header *dm)
{ {
int i, count = (dm->length - sizeof(struct dmi_header)) / 2; int i, count = (dm->length - sizeof(struct dmi_header)) / 2;
struct dmi_device *dev; struct dmi_device *dev;
for (i = 0; i < count; i++) { for (i = 0; i < count; i++) {
char *d = (char *)(dm + 1) + (i * 2); const char *d = (char *)(dm + 1) + (i * 2);
/* Skip disabled device */ /* Skip disabled device */
if ((*d & 0x80) == 0) if ((*d & 0x80) == 0)
...@@ -173,7 +175,7 @@ static void __init dmi_save_devices(struct dmi_header *dm) ...@@ -173,7 +175,7 @@ static void __init dmi_save_devices(struct dmi_header *dm)
} }
} }
static void __init dmi_save_oem_strings_devices(struct dmi_header *dm) static void __init dmi_save_oem_strings_devices(const struct dmi_header *dm)
{ {
int i, count = *(u8 *)(dm + 1); int i, count = *(u8 *)(dm + 1);
struct dmi_device *dev; struct dmi_device *dev;
...@@ -194,7 +196,7 @@ static void __init dmi_save_oem_strings_devices(struct dmi_header *dm) ...@@ -194,7 +196,7 @@ static void __init dmi_save_oem_strings_devices(struct dmi_header *dm)
} }
} }
static void __init dmi_save_ipmi_device(struct dmi_header *dm) static void __init dmi_save_ipmi_device(const struct dmi_header *dm)
{ {
struct dmi_device *dev; struct dmi_device *dev;
void * data; void * data;
...@@ -225,7 +227,7 @@ static void __init dmi_save_ipmi_device(struct dmi_header *dm) ...@@ -225,7 +227,7 @@ static void __init dmi_save_ipmi_device(struct dmi_header *dm)
* and machine entries. For 2.5 we should pull the smbus controller info * and machine entries. For 2.5 we should pull the smbus controller info
* out of here. * out of here.
*/ */
static void __init dmi_decode(struct dmi_header *dm) static void __init dmi_decode(const struct dmi_header *dm)
{ {
switch(dm->type) { switch(dm->type) {
case 0: /* BIOS Information */ case 0: /* BIOS Information */
...@@ -265,9 +267,10 @@ static void __init dmi_decode(struct dmi_header *dm) ...@@ -265,9 +267,10 @@ static void __init dmi_decode(struct dmi_header *dm)
} }
} }
static int __init dmi_present(char __iomem *p) static int __init dmi_present(const char __iomem *p)
{ {
u8 buf[15]; u8 buf[15];
memcpy_fromio(buf, p, 15); memcpy_fromio(buf, p, 15);
if ((memcmp(buf, "_DMI_", 5) == 0) && dmi_checksum(buf)) { if ((memcmp(buf, "_DMI_", 5) == 0) && dmi_checksum(buf)) {
u16 num = (buf[13] << 8) | buf[12]; u16 num = (buf[13] << 8) | buf[12];
...@@ -348,10 +351,10 @@ void __init dmi_scan_machine(void) ...@@ -348,10 +351,10 @@ void __init dmi_scan_machine(void)
* returns non zero or we hit the end. Callback function is called for * returns non zero or we hit the end. Callback function is called for
* each successful match. Returns the number of matches. * each successful match. Returns the number of matches.
*/ */
int dmi_check_system(struct dmi_system_id *list) int dmi_check_system(const struct dmi_system_id *list)
{ {
int i, count = 0; int i, count = 0;
struct dmi_system_id *d = list; const struct dmi_system_id *d = list;
while (d->ident) { while (d->ident) {
for (i = 0; i < ARRAY_SIZE(d->matches); i++) { for (i = 0; i < ARRAY_SIZE(d->matches); i++) {
...@@ -380,7 +383,7 @@ EXPORT_SYMBOL(dmi_check_system); ...@@ -380,7 +383,7 @@ EXPORT_SYMBOL(dmi_check_system);
* Returns one DMI data value, can be used to perform * Returns one DMI data value, can be used to perform
* complex DMI data checks. * complex DMI data checks.
*/ */
char *dmi_get_system_info(int field) const char *dmi_get_system_info(int field)
{ {
return dmi_ident[field]; return dmi_ident[field];
} }
...@@ -391,7 +394,7 @@ EXPORT_SYMBOL(dmi_get_system_info); ...@@ -391,7 +394,7 @@ EXPORT_SYMBOL(dmi_get_system_info);
* dmi_name_in_vendors - Check if string is anywhere in the DMI vendor information. * dmi_name_in_vendors - Check if string is anywhere in the DMI vendor information.
* @str: Case sensitive Name * @str: Case sensitive Name
*/ */
int dmi_name_in_vendors(char *str) int dmi_name_in_vendors(const char *str)
{ {
static int fields[] = { DMI_BIOS_VENDOR, DMI_BIOS_VERSION, DMI_SYS_VENDOR, static int fields[] = { DMI_BIOS_VENDOR, DMI_BIOS_VERSION, DMI_SYS_VENDOR,
DMI_PRODUCT_NAME, DMI_PRODUCT_VERSION, DMI_BOARD_VENDOR, DMI_PRODUCT_NAME, DMI_PRODUCT_VERSION, DMI_BOARD_VENDOR,
...@@ -418,13 +421,15 @@ EXPORT_SYMBOL(dmi_name_in_vendors); ...@@ -418,13 +421,15 @@ EXPORT_SYMBOL(dmi_name_in_vendors);
* A new search is initiated by passing %NULL as the @from argument. * A new search is initiated by passing %NULL as the @from argument.
* If @from is not %NULL, searches continue from next device. * If @from is not %NULL, searches continue from next device.
*/ */
struct dmi_device * dmi_find_device(int type, const char *name, const struct dmi_device * dmi_find_device(int type, const char *name,
struct dmi_device *from) const struct dmi_device *from)
{ {
struct list_head *d, *head = from ? &from->list : &dmi_devices; const struct list_head *head = from ? &from->list : &dmi_devices;
struct list_head *d;
for(d = head->next; d != &dmi_devices; d = d->next) { for(d = head->next; d != &dmi_devices; d = d->next) {
struct dmi_device *dev = list_entry(d, struct dmi_device, list); const struct dmi_device *dev =
list_entry(d, struct dmi_device, list);
if (((type == DMI_DEV_TYPE_ANY) || (dev->type == type)) && if (((type == DMI_DEV_TYPE_ANY) || (dev->type == type)) &&
((name == NULL) || (strcmp(dev->name, name) == 0))) ((name == NULL) || (strcmp(dev->name, name) == 0)))
...@@ -444,7 +449,7 @@ EXPORT_SYMBOL(dmi_find_device); ...@@ -444,7 +449,7 @@ EXPORT_SYMBOL(dmi_find_device);
int dmi_get_year(int field) int dmi_get_year(int field)
{ {
int year; int year;
char *s = dmi_get_system_info(field); const char *s = dmi_get_system_info(field);
if (!s) if (!s)
return -1; return -1;
......
...@@ -1449,7 +1449,7 @@ static int __init abituguru_init(void) ...@@ -1449,7 +1449,7 @@ static int __init abituguru_init(void)
struct resource res = { .flags = IORESOURCE_IO }; struct resource res = { .flags = IORESOURCE_IO };
#ifdef CONFIG_DMI #ifdef CONFIG_DMI
char *board_vendor = dmi_get_system_info(DMI_BOARD_VENDOR); const char *board_vendor = dmi_get_system_info(DMI_BOARD_VENDOR);
/* safety check, refuse to load on non Abit motherboards */ /* safety check, refuse to load on non Abit motherboards */
if (!force && (!board_vendor || if (!force && (!board_vendor ||
......
...@@ -1071,7 +1071,7 @@ static const struct attribute_group temperature_attributes_group = ...@@ -1071,7 +1071,7 @@ static const struct attribute_group temperature_attributes_group =
/* /*
* applesmc_dmi_match - found a match. return one, short-circuiting the hunt. * applesmc_dmi_match - found a match. return one, short-circuiting the hunt.
*/ */
static int applesmc_dmi_match(struct dmi_system_id *id) static int applesmc_dmi_match(const struct dmi_system_id *id)
{ {
int i = 0; int i = 0;
struct dmi_match_data* dmi_data = id->driver_data; struct dmi_match_data* dmi_data = id->driver_data;
......
...@@ -480,14 +480,14 @@ static struct attribute_group hdaps_attribute_group = { ...@@ -480,14 +480,14 @@ static struct attribute_group hdaps_attribute_group = {
/* Module stuff */ /* Module stuff */
/* hdaps_dmi_match - found a match. return one, short-circuiting the hunt. */ /* hdaps_dmi_match - found a match. return one, short-circuiting the hunt. */
static int __init hdaps_dmi_match(struct dmi_system_id *id) static int __init hdaps_dmi_match(const struct dmi_system_id *id)
{ {
printk(KERN_INFO "hdaps: %s detected.\n", id->ident); printk(KERN_INFO "hdaps: %s detected.\n", id->ident);
return 1; return 1;
} }
/* hdaps_dmi_match_invert - found an inverted match. */ /* hdaps_dmi_match_invert - found an inverted match. */
static int __init hdaps_dmi_match_invert(struct dmi_system_id *id) static int __init hdaps_dmi_match_invert(const struct dmi_system_id *id)
{ {
hdaps_invert = 1; hdaps_invert = 1;
printk(KERN_INFO "hdaps: inverting axis readings.\n"); printk(KERN_INFO "hdaps: inverting axis readings.\n");
......
...@@ -588,7 +588,7 @@ static unsigned int __devinit init_chipset_ali15x3 (struct pci_dev *dev, const c ...@@ -588,7 +588,7 @@ static unsigned int __devinit init_chipset_ali15x3 (struct pci_dev *dev, const c
* Cable special cases * Cable special cases
*/ */
static struct dmi_system_id cable_dmi_table[] = { static const struct dmi_system_id cable_dmi_table[] = {
{ {
.ident = "HP Pavilion N5430", .ident = "HP Pavilion N5430",
.matches = { .matches = {
......
...@@ -419,7 +419,7 @@ static unsigned int __devinit init_chipset_via82cxxx(struct pci_dev *dev, const ...@@ -419,7 +419,7 @@ static unsigned int __devinit init_chipset_via82cxxx(struct pci_dev *dev, const
* Cable special cases * Cable special cases
*/ */
static struct dmi_system_id cable_dmi_table[] = { static const struct dmi_system_id cable_dmi_table[] = {
{ {
.ident = "Acer Ferrari 3400", .ident = "Acer Ferrari 3400",
.matches = { .matches = {
......
...@@ -247,7 +247,7 @@ static int have_wifi; ...@@ -247,7 +247,7 @@ static int have_wifi;
static int have_bluetooth; static int have_bluetooth;
static int have_leds; static int have_leds;
static int __init dmi_matched(struct dmi_system_id *dmi) static int __init dmi_matched(const struct dmi_system_id *dmi)
{ {
const struct key_entry *key; const struct key_entry *key;
......
...@@ -27,7 +27,7 @@ struct lifebook_data { ...@@ -27,7 +27,7 @@ struct lifebook_data {
static const char *desired_serio_phys; static const char *desired_serio_phys;
static int lifebook_set_serio_phys(struct dmi_system_id *d) static int lifebook_set_serio_phys(const struct dmi_system_id *d)
{ {
desired_serio_phys = d->driver_data; desired_serio_phys = d->driver_data;
return 0; return 0;
...@@ -35,13 +35,13 @@ static int lifebook_set_serio_phys(struct dmi_system_id *d) ...@@ -35,13 +35,13 @@ static int lifebook_set_serio_phys(struct dmi_system_id *d)
static unsigned char lifebook_use_6byte_proto; static unsigned char lifebook_use_6byte_proto;
static int lifebook_set_6byte_proto(struct dmi_system_id *d) static int lifebook_set_6byte_proto(const struct dmi_system_id *d)
{ {
lifebook_use_6byte_proto = 1; lifebook_use_6byte_proto = 1;
return 0; return 0;
} }
static struct dmi_system_id lifebook_dmi_table[] = { static const struct dmi_system_id lifebook_dmi_table[] = {
{ {
.ident = "FLORA-ie 55mi", .ident = "FLORA-ie 55mi",
.matches = { .matches = {
......
...@@ -602,7 +602,7 @@ static int synaptics_reconnect(struct psmouse *psmouse) ...@@ -602,7 +602,7 @@ static int synaptics_reconnect(struct psmouse *psmouse)
#if defined(__i386__) #if defined(__i386__)
#include <linux/dmi.h> #include <linux/dmi.h>
static struct dmi_system_id toshiba_dmi_table[] = { static const struct dmi_system_id toshiba_dmi_table[] = {
{ {
.ident = "Toshiba Satellite", .ident = "Toshiba Satellite",
.matches = { .matches = {
......
...@@ -283,7 +283,7 @@ static struct platform_device *msipf_device; ...@@ -283,7 +283,7 @@ static struct platform_device *msipf_device;
/* Initialization */ /* Initialization */
static int dmi_check_cb(struct dmi_system_id *id) static int dmi_check_cb(const struct dmi_system_id *id)
{ {
printk("msi-laptop: Identified laptop model '%s'.\n", id->ident); printk("msi-laptop: Identified laptop model '%s'.\n", id->ident);
return 0; return 0;
......
...@@ -807,7 +807,7 @@ static struct sony_nc_event *sony_nc_events; ...@@ -807,7 +807,7 @@ static struct sony_nc_event *sony_nc_events;
/* Vaio C* --maybe also FE*, N* and AR* ?-- special init sequence /* Vaio C* --maybe also FE*, N* and AR* ?-- special init sequence
* for Fn keys * for Fn keys
*/ */
static int sony_nc_C_enable(struct dmi_system_id *id) static int sony_nc_C_enable(const struct dmi_system_id *id)
{ {
int result = 0; int result = 0;
...@@ -845,7 +845,7 @@ static struct sony_nc_event sony_C_events[] = { ...@@ -845,7 +845,7 @@ static struct sony_nc_event sony_C_events[] = {
}; };
/* SNC-only model map */ /* SNC-only model map */
static struct dmi_system_id sony_nc_ids[] = { static const struct dmi_system_id sony_nc_ids[] = {
{ {
.ident = "Sony Vaio FE Series", .ident = "Sony Vaio FE Series",
.callback = sony_nc_C_enable, .callback = sony_nc_C_enable,
......
...@@ -4448,7 +4448,7 @@ static void ibm_exit(struct ibm_struct *ibm) ...@@ -4448,7 +4448,7 @@ static void ibm_exit(struct ibm_struct *ibm)
static void __init get_thinkpad_model_data(struct thinkpad_id_data *tp) static void __init get_thinkpad_model_data(struct thinkpad_id_data *tp)
{ {
struct dmi_device *dev = NULL; const struct dmi_device *dev = NULL;
char ec_fw_string[18]; char ec_fw_string[18];
if (!tp) if (!tp)
......
...@@ -500,7 +500,7 @@ static int __init pnpbios_probe_system(void) ...@@ -500,7 +500,7 @@ static int __init pnpbios_probe_system(void)
return 0; return 0;
} }
static int __init exploding_pnp_bios(struct dmi_system_id *d) static int __init exploding_pnp_bios(const struct dmi_system_id *d)
{ {
printk(KERN_WARNING "%s detected. Disabling PnPBIOS\n", d->ident); printk(KERN_WARNING "%s detected. Disabling PnPBIOS\n", d->ident);
return 0; return 0;
......
...@@ -237,7 +237,7 @@ static int resume_detect_interrupts_are_broken(struct uhci_hcd *uhci) ...@@ -237,7 +237,7 @@ static int resume_detect_interrupts_are_broken(struct uhci_hcd *uhci)
static int remote_wakeup_is_broken(struct uhci_hcd *uhci) static int remote_wakeup_is_broken(struct uhci_hcd *uhci)
{ {
int port; int port;
char *sys_info; const char *sys_info;
static char bad_Asus_board[] = "A7V8X"; static char bad_Asus_board[] = "A7V8X";
/* One of Asus's motherboards has a bug which causes it to /* One of Asus's motherboards has a bug which causes it to
......
...@@ -58,7 +58,7 @@ static int model = M_UNKNOWN; ...@@ -58,7 +58,7 @@ static int model = M_UNKNOWN;
static int manual_height; static int manual_height;
static int manual_width; static int manual_width;
static int set_system(struct dmi_system_id *id) static int set_system(const struct dmi_system_id *id)
{ {
printk(KERN_INFO "imacfb: %s detected - set system to %ld\n", printk(KERN_INFO "imacfb: %s detected - set system to %ld\n",
id->ident, (long)id->driver_data); id->ident, (long)id->driver_data);
......
...@@ -54,7 +54,7 @@ struct dmi_strmatch { ...@@ -54,7 +54,7 @@ struct dmi_strmatch {
}; };
struct dmi_system_id { struct dmi_system_id {
int (*callback)(struct dmi_system_id *); int (*callback)(const struct dmi_system_id *);
const char *ident; const char *ident;
struct dmi_strmatch matches[4]; struct dmi_strmatch matches[4];
void *driver_data; void *driver_data;
...@@ -71,22 +71,22 @@ struct dmi_device { ...@@ -71,22 +71,22 @@ struct dmi_device {
#ifdef CONFIG_DMI #ifdef CONFIG_DMI
extern int dmi_check_system(struct dmi_system_id *list); extern int dmi_check_system(const struct dmi_system_id *list);
extern char * dmi_get_system_info(int field); extern const char * dmi_get_system_info(int field);
extern struct dmi_device * dmi_find_device(int type, const char *name, extern const struct dmi_device * dmi_find_device(int type, const char *name,
struct dmi_device *from); const struct dmi_device *from);
extern void dmi_scan_machine(void); extern void dmi_scan_machine(void);
extern int dmi_get_year(int field); extern int dmi_get_year(int field);
extern int dmi_name_in_vendors(char *str); extern int dmi_name_in_vendors(const char *str);
#else #else
static inline int dmi_check_system(struct dmi_system_id *list) { return 0; } static inline int dmi_check_system(const struct dmi_system_id *list) { return 0; }
static inline char * dmi_get_system_info(int field) { return NULL; } static inline const char * dmi_get_system_info(int field) { return NULL; }
static inline struct dmi_device * dmi_find_device(int type, const char *name, static inline const struct dmi_device * dmi_find_device(int type, const char *name,
struct dmi_device *from) { return NULL; } const struct dmi_device *from) { return NULL; }
static inline int dmi_get_year(int year) { return 0; } static inline int dmi_get_year(int year) { return 0; }
static inline int dmi_name_in_vendors(char *s) { return 0; } static inline int dmi_name_in_vendors(const char *s) { return 0; }
#endif #endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment