Commit 1b138131 authored by David S. Miller's avatar David S. Miller

Merge branch 'pci_set_drvdata'

Jingoo Han says:

====================
net: ethernet: remove unnecessary pci_set_drvdata() part 3

Since commit 0998d063
(device-core: Ensure drvdata = NULL when no driver is bound),
the driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
====================
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parents bda301c9 877a22cd
...@@ -1870,7 +1870,6 @@ static void pasemi_mac_remove(struct pci_dev *pdev) ...@@ -1870,7 +1870,6 @@ static void pasemi_mac_remove(struct pci_dev *pdev)
pasemi_dma_free_chan(&mac->tx->chan); pasemi_dma_free_chan(&mac->tx->chan);
pasemi_dma_free_chan(&mac->rx->chan); pasemi_dma_free_chan(&mac->rx->chan);
pci_set_drvdata(pdev, NULL);
free_netdev(netdev); free_netdev(netdev);
} }
......
...@@ -1630,7 +1630,6 @@ netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) ...@@ -1630,7 +1630,6 @@ netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
pci_release_regions(pdev); pci_release_regions(pdev);
err_out_disable_pdev: err_out_disable_pdev:
pci_set_drvdata(pdev, NULL);
pci_disable_device(pdev); pci_disable_device(pdev);
return err; return err;
} }
...@@ -1689,7 +1688,6 @@ static void netxen_nic_remove(struct pci_dev *pdev) ...@@ -1689,7 +1688,6 @@ static void netxen_nic_remove(struct pci_dev *pdev)
pci_release_regions(pdev); pci_release_regions(pdev);
pci_disable_device(pdev); pci_disable_device(pdev);
pci_set_drvdata(pdev, NULL);
free_netdev(netdev); free_netdev(netdev);
} }
......
...@@ -3916,7 +3916,6 @@ static int ql3xxx_probe(struct pci_dev *pdev, ...@@ -3916,7 +3916,6 @@ static int ql3xxx_probe(struct pci_dev *pdev,
pci_release_regions(pdev); pci_release_regions(pdev);
err_out_disable_pdev: err_out_disable_pdev:
pci_disable_device(pdev); pci_disable_device(pdev);
pci_set_drvdata(pdev, NULL);
err_out: err_out:
return err; return err;
} }
...@@ -3939,7 +3938,6 @@ static void ql3xxx_remove(struct pci_dev *pdev) ...@@ -3939,7 +3938,6 @@ static void ql3xxx_remove(struct pci_dev *pdev)
iounmap(qdev->mem_map_registers); iounmap(qdev->mem_map_registers);
pci_release_regions(pdev); pci_release_regions(pdev);
pci_set_drvdata(pdev, NULL);
free_netdev(ndev); free_netdev(ndev);
} }
......
...@@ -2406,7 +2406,6 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) ...@@ -2406,7 +2406,6 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
pci_release_regions(pdev); pci_release_regions(pdev);
err_out_disable_pdev: err_out_disable_pdev:
pci_set_drvdata(pdev, NULL);
pci_disable_device(pdev); pci_disable_device(pdev);
return err; return err;
...@@ -2482,7 +2481,6 @@ static void qlcnic_remove(struct pci_dev *pdev) ...@@ -2482,7 +2481,6 @@ static void qlcnic_remove(struct pci_dev *pdev)
pci_disable_pcie_error_reporting(pdev); pci_disable_pcie_error_reporting(pdev);
pci_release_regions(pdev); pci_release_regions(pdev);
pci_disable_device(pdev); pci_disable_device(pdev);
pci_set_drvdata(pdev, NULL);
if (adapter->qlcnic_wq) { if (adapter->qlcnic_wq) {
destroy_workqueue(adapter->qlcnic_wq); destroy_workqueue(adapter->qlcnic_wq);
......
...@@ -4577,7 +4577,6 @@ static void ql_release_all(struct pci_dev *pdev) ...@@ -4577,7 +4577,6 @@ static void ql_release_all(struct pci_dev *pdev)
iounmap(qdev->doorbell_area); iounmap(qdev->doorbell_area);
vfree(qdev->mpi_coredump); vfree(qdev->mpi_coredump);
pci_release_regions(pdev); pci_release_regions(pdev);
pci_set_drvdata(pdev, NULL);
} }
static int ql_init_device(struct pci_dev *pdev, struct net_device *ndev, static int ql_init_device(struct pci_dev *pdev, struct net_device *ndev,
......
...@@ -1231,7 +1231,6 @@ static int r6040_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) ...@@ -1231,7 +1231,6 @@ static int r6040_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
mdiobus_free(lp->mii_bus); mdiobus_free(lp->mii_bus);
err_out_unmap: err_out_unmap:
netif_napi_del(&lp->napi); netif_napi_del(&lp->napi);
pci_set_drvdata(pdev, NULL);
pci_iounmap(pdev, ioaddr); pci_iounmap(pdev, ioaddr);
err_out_free_res: err_out_free_res:
pci_release_regions(pdev); pci_release_regions(pdev);
...@@ -1257,7 +1256,6 @@ static void r6040_remove_one(struct pci_dev *pdev) ...@@ -1257,7 +1256,6 @@ static void r6040_remove_one(struct pci_dev *pdev)
pci_release_regions(pdev); pci_release_regions(pdev);
free_netdev(dev); free_netdev(dev);
pci_disable_device(pdev); pci_disable_device(pdev);
pci_set_drvdata(pdev, NULL);
} }
......
...@@ -2052,7 +2052,6 @@ static void cp_remove_one (struct pci_dev *pdev) ...@@ -2052,7 +2052,6 @@ static void cp_remove_one (struct pci_dev *pdev)
pci_release_regions(pdev); pci_release_regions(pdev);
pci_clear_mwi(pdev); pci_clear_mwi(pdev);
pci_disable_device(pdev); pci_disable_device(pdev);
pci_set_drvdata(pdev, NULL);
free_netdev(dev); free_netdev(dev);
} }
......
...@@ -727,7 +727,6 @@ static void __rtl8139_cleanup_dev (struct net_device *dev) ...@@ -727,7 +727,6 @@ static void __rtl8139_cleanup_dev (struct net_device *dev)
pci_release_regions (pdev); pci_release_regions (pdev);
free_netdev(dev); free_netdev(dev);
pci_set_drvdata (pdev, NULL);
} }
......
...@@ -6811,7 +6811,6 @@ static void rtl_remove_one(struct pci_dev *pdev) ...@@ -6811,7 +6811,6 @@ static void rtl_remove_one(struct pci_dev *pdev)
rtl_disable_msi(pdev, tp); rtl_disable_msi(pdev, tp);
rtl8169_release_board(pdev, dev, tp->mmio_addr); rtl8169_release_board(pdev, dev, tp->mmio_addr);
pci_set_drvdata(pdev, NULL);
} }
static const struct net_device_ops rtl_netdev_ops = { static const struct net_device_ops rtl_netdev_ops = {
......
...@@ -1921,7 +1921,6 @@ static void sis190_remove_one(struct pci_dev *pdev) ...@@ -1921,7 +1921,6 @@ static void sis190_remove_one(struct pci_dev *pdev)
cancel_work_sync(&tp->phy_task); cancel_work_sync(&tp->phy_task);
unregister_netdev(dev); unregister_netdev(dev);
sis190_release_board(pdev); sis190_release_board(pdev);
pci_set_drvdata(pdev, NULL);
} }
static struct pci_driver sis190_pci_driver = { static struct pci_driver sis190_pci_driver = {
......
...@@ -1535,7 +1535,6 @@ static void epic_remove_one(struct pci_dev *pdev) ...@@ -1535,7 +1535,6 @@ static void epic_remove_one(struct pci_dev *pdev)
pci_release_regions(pdev); pci_release_regions(pdev);
free_netdev(dev); free_netdev(dev);
pci_disable_device(pdev); pci_disable_device(pdev);
pci_set_drvdata(pdev, NULL);
/* pci_power_off(pdev, -1); */ /* pci_power_off(pdev, -1); */
} }
......
...@@ -1707,8 +1707,6 @@ static void smsc9420_remove(struct pci_dev *pdev) ...@@ -1707,8 +1707,6 @@ static void smsc9420_remove(struct pci_dev *pdev)
if (!dev) if (!dev)
return; return;
pci_set_drvdata(pdev, NULL);
pd = netdev_priv(dev); pd = netdev_priv(dev);
unregister_netdev(dev); unregister_netdev(dev);
......
...@@ -138,7 +138,6 @@ static void stmmac_pci_remove(struct pci_dev *pdev) ...@@ -138,7 +138,6 @@ static void stmmac_pci_remove(struct pci_dev *pdev)
stmmac_dvr_remove(ndev); stmmac_dvr_remove(ndev);
pci_set_drvdata(pdev, NULL);
pci_iounmap(pdev, priv->ioaddr); pci_iounmap(pdev, priv->ioaddr);
pci_release_regions(pdev); pci_release_regions(pdev);
pci_disable_device(pdev); pci_disable_device(pdev);
......
...@@ -5168,7 +5168,6 @@ static int cas_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) ...@@ -5168,7 +5168,6 @@ static int cas_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
err_out_disable_pdev: err_out_disable_pdev:
pci_disable_device(pdev); pci_disable_device(pdev);
pci_set_drvdata(pdev, NULL);
return -ENODEV; return -ENODEV;
} }
...@@ -5206,7 +5205,6 @@ static void cas_remove_one(struct pci_dev *pdev) ...@@ -5206,7 +5205,6 @@ static void cas_remove_one(struct pci_dev *pdev)
free_netdev(dev); free_netdev(dev);
pci_release_regions(pdev); pci_release_regions(pdev);
pci_disable_device(pdev); pci_disable_device(pdev);
pci_set_drvdata(pdev, NULL);
} }
#ifdef CONFIG_PM #ifdef CONFIG_PM
......
...@@ -3170,8 +3170,6 @@ static void happy_meal_pci_remove(struct pci_dev *pdev) ...@@ -3170,8 +3170,6 @@ static void happy_meal_pci_remove(struct pci_dev *pdev)
pci_release_regions(hp->happy_dev); pci_release_regions(hp->happy_dev);
free_netdev(net_dev); free_netdev(net_dev);
pci_set_drvdata(pdev, NULL);
} }
static DEFINE_PCI_DEVICE_TABLE(happymeal_pci_ids) = { static DEFINE_PCI_DEVICE_TABLE(happymeal_pci_ids) = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment