Commit 1b3bbcf5 authored by Hans de Goede's avatar Hans de Goede Committed by Mauro Carvalho Chehab

[media] gspca_zc3xx: Disable the highest quality setting as it is not usable

Even with BRC the highest quality setting is not usable, BRC strips so
much data from each MCU that the quality becomes worse then using a lower
quality setting to begin with.
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 55db765c
...@@ -194,7 +194,7 @@ static const struct ctrl sd_ctrls[NCTRLS] = { ...@@ -194,7 +194,7 @@ static const struct ctrl sd_ctrls[NCTRLS] = {
.type = V4L2_CTRL_TYPE_INTEGER, .type = V4L2_CTRL_TYPE_INTEGER,
.name = "Compression Quality", .name = "Compression Quality",
.minimum = 50, .minimum = 50,
.maximum = 94, .maximum = 87,
.step = 1, .step = 1,
.default_value = 75, .default_value = 75,
}, },
...@@ -241,8 +241,11 @@ static const struct v4l2_pix_format sif_mode[] = { ...@@ -241,8 +241,11 @@ static const struct v4l2_pix_format sif_mode[] = {
.priv = 0}, .priv = 0},
}; };
/* bridge reg08 bits 1-2 -> JPEG quality conversion table */ /*
static u8 jpeg_qual[] = {50, 75, 87, 94}; * Bridge reg08 bits 1-2 -> JPEG quality conversion table. Note the highest
* quality setting is not usable as USB 1 does not have enough bandwidth.
*/
static u8 jpeg_qual[] = {50, 75, 87, /* 94 */};
/* usb exchanges */ /* usb exchanges */
struct usb_action { struct usb_action {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment