Commit 1bdceede authored by Stephen Hemminger's avatar Stephen Hemminger Committed by David S. Miller

[PKT_SCHED]: netem: memory leak

Good catch.. netem needs to free skb's that are dropped due to loss
simulation.
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 70c0a5c1
...@@ -177,6 +177,7 @@ static int netem_enqueue(struct sk_buff *skb, struct Qdisc *sch) ...@@ -177,6 +177,7 @@ static int netem_enqueue(struct sk_buff *skb, struct Qdisc *sch)
if (q->loss && q->loss >= get_crandom(&q->loss_cor)) { if (q->loss && q->loss >= get_crandom(&q->loss_cor)) {
pr_debug("netem_enqueue: random loss\n"); pr_debug("netem_enqueue: random loss\n");
sch->qstats.drops++; sch->qstats.drops++;
kfree_skb(skb);
return 0; /* lie about loss so TCP doesn't know */ return 0; /* lie about loss so TCP doesn't know */
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment