Commit 1f3d2d9e authored by Himangi Saraogi's avatar Himangi Saraogi Committed by Christoph Hellwig

aic7xxx: Use kstrdup

Use kstrdup when the goal of an allocation is copy a string into the
allocated region.

The Coccinelle semantic patch that makes this change is as follows:

// <smpl>
@@
expression from,to;
expression flag,E1,E2;
statement S;
@@

-  to = kmalloc(strlen(from) + 1,flag);
+  to = kstrdup(from, flag);
   ... when != \(from = E1 \| to = E1 \)
   if (to==NULL || ...) S
   ... when != \(from = E2 \| to = E2 \)
-  strcpy(to, from);
// </smpl>
Signed-off-by: default avatarHimangi Saraogi <himangi774@gmail.com>
Acked-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent c21a2c1a
...@@ -85,10 +85,9 @@ aic7770_probe(struct device *dev) ...@@ -85,10 +85,9 @@ aic7770_probe(struct device *dev)
int error; int error;
sprintf(buf, "ahc_eisa:%d", eisaBase >> 12); sprintf(buf, "ahc_eisa:%d", eisaBase >> 12);
name = kmalloc(strlen(buf) + 1, GFP_ATOMIC); name = kstrdup(buf, GFP_ATOMIC);
if (name == NULL) if (name == NULL)
return (ENOMEM); return (ENOMEM);
strcpy(name, buf);
ahc = ahc_alloc(&aic7xxx_driver_template, name); ahc = ahc_alloc(&aic7xxx_driver_template, name);
if (ahc == NULL) if (ahc == NULL)
return (ENOMEM); return (ENOMEM);
......
...@@ -178,10 +178,9 @@ ahd_linux_pci_dev_probe(struct pci_dev *pdev, const struct pci_device_id *ent) ...@@ -178,10 +178,9 @@ ahd_linux_pci_dev_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
ahd_get_pci_bus(pci), ahd_get_pci_bus(pci),
ahd_get_pci_slot(pci), ahd_get_pci_slot(pci),
ahd_get_pci_function(pci)); ahd_get_pci_function(pci));
name = kmalloc(strlen(buf) + 1, GFP_ATOMIC); name = kstrdup(buf, GFP_ATOMIC);
if (name == NULL) if (name == NULL)
return (-ENOMEM); return (-ENOMEM);
strcpy(name, buf);
ahd = ahd_alloc(NULL, name); ahd = ahd_alloc(NULL, name);
if (ahd == NULL) if (ahd == NULL)
return (-ENOMEM); return (-ENOMEM);
......
...@@ -225,10 +225,9 @@ ahc_linux_pci_dev_probe(struct pci_dev *pdev, const struct pci_device_id *ent) ...@@ -225,10 +225,9 @@ ahc_linux_pci_dev_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
ahc_get_pci_bus(pci), ahc_get_pci_bus(pci),
ahc_get_pci_slot(pci), ahc_get_pci_slot(pci),
ahc_get_pci_function(pci)); ahc_get_pci_function(pci));
name = kmalloc(strlen(buf) + 1, GFP_ATOMIC); name = kstrdup(buf, GFP_ATOMIC);
if (name == NULL) if (name == NULL)
return (-ENOMEM); return (-ENOMEM);
strcpy(name, buf);
ahc = ahc_alloc(NULL, name); ahc = ahc_alloc(NULL, name);
if (ahc == NULL) if (ahc == NULL)
return (-ENOMEM); return (-ENOMEM);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment