Commit 1fcd86b5 authored by John Fastabend's avatar John Fastabend Committed by Jeff Kirsher

ixgbe: dcbnl reduce duplicated code and indentation

Replace duplicated code in if/else branches with single
check and ixgbe_init_interrupt_scheme().
Signed-off-by: default avatarJohn Fastabend <john.r.fastabend@intel.com>
Tested-by: default avatarRoss Brattain <ross.b.brattain@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent c12db769
...@@ -146,37 +146,34 @@ static u8 ixgbe_dcbnl_set_state(struct net_device *netdev, u8 state) ...@@ -146,37 +146,34 @@ static u8 ixgbe_dcbnl_set_state(struct net_device *netdev, u8 state)
adapter->flags |= IXGBE_FLAG_DCB_ENABLED; adapter->flags |= IXGBE_FLAG_DCB_ENABLED;
if (!netdev_get_num_tc(netdev)) if (!netdev_get_num_tc(netdev))
ixgbe_setup_tc(netdev, MAX_TRAFFIC_CLASS); ixgbe_setup_tc(netdev, MAX_TRAFFIC_CLASS);
ixgbe_init_interrupt_scheme(adapter);
if (netif_running(netdev))
netdev->netdev_ops->ndo_open(netdev);
} else { } else {
/* Turn off DCB */ /* Turn off DCB */
if (adapter->flags & IXGBE_FLAG_DCB_ENABLED) { if (!(adapter->flags & IXGBE_FLAG_DCB_ENABLED))
if (netif_running(netdev)) goto out;
netdev->netdev_ops->ndo_stop(netdev);
ixgbe_clear_interrupt_scheme(adapter);
adapter->hw.fc.requested_mode = adapter->last_lfc_mode; if (netif_running(netdev))
adapter->temp_dcb_cfg.pfc_mode_enable = false; netdev->netdev_ops->ndo_stop(netdev);
adapter->dcb_cfg.pfc_mode_enable = false; ixgbe_clear_interrupt_scheme(adapter);
adapter->flags &= ~IXGBE_FLAG_DCB_ENABLED;
switch (adapter->hw.mac.type) { adapter->hw.fc.requested_mode = adapter->last_lfc_mode;
case ixgbe_mac_82599EB: adapter->temp_dcb_cfg.pfc_mode_enable = false;
case ixgbe_mac_X540: adapter->dcb_cfg.pfc_mode_enable = false;
adapter->flags |= IXGBE_FLAG_FDIR_HASH_CAPABLE; adapter->flags &= ~IXGBE_FLAG_DCB_ENABLED;
break; switch (adapter->hw.mac.type) {
default: case ixgbe_mac_82599EB:
break; case ixgbe_mac_X540:
} adapter->flags |= IXGBE_FLAG_FDIR_HASH_CAPABLE;
break;
ixgbe_setup_tc(netdev, 0); default:
break;
ixgbe_init_interrupt_scheme(adapter);
if (netif_running(netdev))
netdev->netdev_ops->ndo_open(netdev);
} }
ixgbe_setup_tc(netdev, 0);
} }
ixgbe_init_interrupt_scheme(adapter);
if (netif_running(netdev))
netdev->netdev_ops->ndo_open(netdev);
out: out:
return err; return err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment