Commit 201c44bd authored by Jakub Kicinski's avatar Jakub Kicinski Committed by David S. Miller

net: cls_u32: be more strict about skip-sw flag for knodes

Return an error if user requested skip-sw and the underlaying
hardware cannot handle tc offloads (or offloads are disabled).
This patch fixes the knode handling.
Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6eef3801
...@@ -508,27 +508,28 @@ static int u32_replace_hw_knode(struct tcf_proto *tp, ...@@ -508,27 +508,28 @@ static int u32_replace_hw_knode(struct tcf_proto *tp,
offload.type = TC_SETUP_CLSU32; offload.type = TC_SETUP_CLSU32;
offload.cls_u32 = &u32_offload; offload.cls_u32 = &u32_offload;
if (tc_should_offload(dev, tp, flags)) { if (!tc_should_offload(dev, tp, flags))
offload.cls_u32->command = TC_CLSU32_REPLACE_KNODE; return tc_skip_sw(flags) ? -EINVAL : 0;
offload.cls_u32->knode.handle = n->handle;
offload.cls_u32->knode.fshift = n->fshift; offload.cls_u32->command = TC_CLSU32_REPLACE_KNODE;
offload.cls_u32->knode.handle = n->handle;
offload.cls_u32->knode.fshift = n->fshift;
#ifdef CONFIG_CLS_U32_MARK #ifdef CONFIG_CLS_U32_MARK
offload.cls_u32->knode.val = n->val; offload.cls_u32->knode.val = n->val;
offload.cls_u32->knode.mask = n->mask; offload.cls_u32->knode.mask = n->mask;
#else #else
offload.cls_u32->knode.val = 0; offload.cls_u32->knode.val = 0;
offload.cls_u32->knode.mask = 0; offload.cls_u32->knode.mask = 0;
#endif #endif
offload.cls_u32->knode.sel = &n->sel; offload.cls_u32->knode.sel = &n->sel;
offload.cls_u32->knode.exts = &n->exts; offload.cls_u32->knode.exts = &n->exts;
if (n->ht_down) if (n->ht_down)
offload.cls_u32->knode.link_handle = n->ht_down->handle; offload.cls_u32->knode.link_handle = n->ht_down->handle;
err = dev->netdev_ops->ndo_setup_tc(dev, tp->q->handle, err = dev->netdev_ops->ndo_setup_tc(dev, tp->q->handle,
tp->protocol, &offload); tp->protocol, &offload);
if (tc_skip_sw(flags)) if (tc_skip_sw(flags))
return err; return err;
}
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment