Commit 2069d483 authored by Takashi Iwai's avatar Takashi Iwai

ALSA: vmaster: Fix slave change notification

When a value of a vmaster slave control is changed, the ctl change
notification is sometimes ignored.  This happens when the master
control overrides, e.g. when the corresponding master control is
muted.  The reason is that slave_put() returns the value of the actual
slave put callback, and it doesn't reflect the virtual slave value
change.

This patch fixes the function just to return 1 whenever a slave value
is changed.

Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 85c50a58
...@@ -213,7 +213,10 @@ static int slave_put(struct snd_kcontrol *kcontrol, ...@@ -213,7 +213,10 @@ static int slave_put(struct snd_kcontrol *kcontrol,
} }
if (!changed) if (!changed)
return 0; return 0;
return slave_put_val(slave, ucontrol); err = slave_put_val(slave, ucontrol);
if (err < 0)
return err;
return 1;
} }
static int slave_tlv_cmd(struct snd_kcontrol *kcontrol, static int slave_tlv_cmd(struct snd_kcontrol *kcontrol,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment