Commit 2193eb96 authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown

ASoC: Intel: boards: remove hard-coded compressed dailinks

The hard-coded compressed dailinks are not supported using
publicly-available firmwares, which creates unnecessary user
confusion [1]. Even if the firmware was available, the mainline
code does not have the required .dynamic=1 and .dpcm_playback=1
fields so probably never worked as is, and last and they conflict
with topology-defined streams.

Remove them and move on. This can be re-enabled with SOF later
in a more flexible manner.

[1] http://mailman.alsa-project.org/pipermail/alsa-devel/2017-August/124868.htmlSigned-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Acked-by: default avatarLiam Girdwood <liam.r.girdwood@linux.intel.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 149f7757
...@@ -185,14 +185,6 @@ static struct snd_soc_dai_link dailink[] = { ...@@ -185,14 +185,6 @@ static struct snd_soc_dai_link dailink[] = {
.dpcm_playback = 1, .dpcm_playback = 1,
.ops = &aif1_ops, .ops = &aif1_ops,
}, },
[MERR_DPCM_COMPR] = {
.name = "Compressed Port",
.stream_name = "Compress",
.cpu_dai_name = "compress-cpu-dai",
.codec_dai_name = "snd-soc-dummy-dai",
.codec_name = "snd-soc-dummy",
.platform_name = "sst-mfld-platform",
},
/* CODEC<->CODEC link */ /* CODEC<->CODEC link */
/* back ends */ /* back ends */
{ {
...@@ -243,7 +235,6 @@ static int bytcht_da7213_probe(struct platform_device *pdev) ...@@ -243,7 +235,6 @@ static int bytcht_da7213_probe(struct platform_device *pdev)
card->dev = &pdev->dev; card->dev = &pdev->dev;
/* fix index of codec dai */ /* fix index of codec dai */
dai_index = MERR_DPCM_COMPR + 1;
for (i = 0; i < ARRAY_SIZE(dailink); i++) { for (i = 0; i < ARRAY_SIZE(dailink); i++) {
if (!strcmp(dailink[i].codec_name, "i2c-DLGS7213:00")) { if (!strcmp(dailink[i].codec_name, "i2c-DLGS7213:00")) {
dai_index = i; dai_index = i;
......
...@@ -194,15 +194,6 @@ static struct snd_soc_dai_link byt_cht_es8316_dais[] = { ...@@ -194,15 +194,6 @@ static struct snd_soc_dai_link byt_cht_es8316_dais[] = {
.ops = &byt_cht_es8316_aif1_ops, .ops = &byt_cht_es8316_aif1_ops,
}, },
[MERR_DPCM_COMPR] = {
.name = "Compressed Port",
.stream_name = "Compress",
.cpu_dai_name = "compress-cpu-dai",
.codec_dai_name = "snd-soc-dummy-dai",
.codec_name = "snd-soc-dummy",
.platform_name = "sst-mfld-platform",
},
/* back ends */ /* back ends */
{ {
/* Only SSP2 has been tested here, so BYT-CR platforms that /* Only SSP2 has been tested here, so BYT-CR platforms that
......
...@@ -133,14 +133,6 @@ static struct snd_soc_dai_link dais[] = { ...@@ -133,14 +133,6 @@ static struct snd_soc_dai_link dais[] = {
.dpcm_playback = 1, .dpcm_playback = 1,
.ops = &aif1_ops, .ops = &aif1_ops,
}, },
[MERR_DPCM_COMPR] = {
.name = "Compressed Port",
.stream_name = "Compress",
.cpu_dai_name = "compress-cpu-dai",
.codec_dai_name = "snd-soc-dummy-dai",
.codec_name = "snd-soc-dummy",
.platform_name = "sst-mfld-platform",
},
/* CODEC<->CODEC link */ /* CODEC<->CODEC link */
/* back ends */ /* back ends */
{ {
......
...@@ -678,14 +678,6 @@ static struct snd_soc_dai_link byt_rt5640_dais[] = { ...@@ -678,14 +678,6 @@ static struct snd_soc_dai_link byt_rt5640_dais[] = {
.dynamic = 1, .dynamic = 1,
.dpcm_playback = 1, .dpcm_playback = 1,
.ops = &byt_rt5640_aif1_ops, .ops = &byt_rt5640_aif1_ops,
},
[MERR_DPCM_COMPR] = {
.name = "Baytrail Compressed Port",
.stream_name = "Baytrail Compress",
.cpu_dai_name = "compress-cpu-dai",
.codec_dai_name = "snd-soc-dummy-dai",
.codec_name = "snd-soc-dummy",
.platform_name = "sst-mfld-platform",
}, },
/* back ends */ /* back ends */
{ {
...@@ -748,7 +740,7 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev) ...@@ -748,7 +740,7 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev)
struct sst_acpi_mach *mach; struct sst_acpi_mach *mach;
const char *i2c_name = NULL; const char *i2c_name = NULL;
int ret_val = 0; int ret_val = 0;
int dai_index; int dai_index = 0;
int i; int i;
is_bytcr = false; is_bytcr = false;
...@@ -762,7 +754,6 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev) ...@@ -762,7 +754,6 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev)
snd_soc_card_set_drvdata(&byt_rt5640_card, priv); snd_soc_card_set_drvdata(&byt_rt5640_card, priv);
/* fix index of codec dai */ /* fix index of codec dai */
dai_index = MERR_DPCM_COMPR + 1;
for (i = 0; i < ARRAY_SIZE(byt_rt5640_dais); i++) { for (i = 0; i < ARRAY_SIZE(byt_rt5640_dais); i++) {
if (!strcmp(byt_rt5640_dais[i].codec_name, "i2c-10EC5640:00")) { if (!strcmp(byt_rt5640_dais[i].codec_name, "i2c-10EC5640:00")) {
dai_index = i; dai_index = i;
......
...@@ -389,14 +389,6 @@ static struct snd_soc_dai_link byt_rt5651_dais[] = { ...@@ -389,14 +389,6 @@ static struct snd_soc_dai_link byt_rt5651_dais[] = {
.dpcm_playback = 1, .dpcm_playback = 1,
.ops = &byt_rt5651_aif1_ops, .ops = &byt_rt5651_aif1_ops,
}, },
[MERR_DPCM_COMPR] = {
.name = "Compressed Port",
.stream_name = "Compress",
.cpu_dai_name = "compress-cpu-dai",
.codec_dai_name = "snd-soc-dummy-dai",
.codec_name = "snd-soc-dummy",
.platform_name = "sst-mfld-platform",
},
/* CODEC<->CODEC link */ /* CODEC<->CODEC link */
/* back ends */ /* back ends */
{ {
...@@ -440,7 +432,7 @@ static int snd_byt_rt5651_mc_probe(struct platform_device *pdev) ...@@ -440,7 +432,7 @@ static int snd_byt_rt5651_mc_probe(struct platform_device *pdev)
struct sst_acpi_mach *mach; struct sst_acpi_mach *mach;
const char *i2c_name = NULL; const char *i2c_name = NULL;
int ret_val = 0; int ret_val = 0;
int dai_index; int dai_index = 0;
int i; int i;
priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_ATOMIC); priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_ATOMIC);
...@@ -454,7 +446,6 @@ static int snd_byt_rt5651_mc_probe(struct platform_device *pdev) ...@@ -454,7 +446,6 @@ static int snd_byt_rt5651_mc_probe(struct platform_device *pdev)
snd_soc_card_set_drvdata(&byt_rt5651_card, priv); snd_soc_card_set_drvdata(&byt_rt5651_card, priv);
/* fix index of codec dai */ /* fix index of codec dai */
dai_index = MERR_DPCM_COMPR + 1;
for (i = 0; i < ARRAY_SIZE(byt_rt5651_dais); i++) { for (i = 0; i < ARRAY_SIZE(byt_rt5651_dais); i++) {
if (!strcmp(byt_rt5651_dais[i].codec_name, "i2c-10EC5651:00")) { if (!strcmp(byt_rt5651_dais[i].codec_name, "i2c-10EC5651:00")) {
dai_index = i; dai_index = i;
......
...@@ -350,14 +350,6 @@ static struct snd_soc_dai_link cht_dailink[] = { ...@@ -350,14 +350,6 @@ static struct snd_soc_dai_link cht_dailink[] = {
.dpcm_playback = 1, .dpcm_playback = 1,
.ops = &cht_aif1_ops, .ops = &cht_aif1_ops,
}, },
[MERR_DPCM_COMPR] = {
.name = "Compressed Port",
.stream_name = "Compress",
.cpu_dai_name = "compress-cpu-dai",
.codec_dai_name = "snd-soc-dummy-dai",
.codec_name = "snd-soc-dummy",
.platform_name = "sst-mfld-platform",
},
/* back ends */ /* back ends */
{ {
.name = "SSP2-Codec", .name = "SSP2-Codec",
......
...@@ -445,14 +445,6 @@ static struct snd_soc_dai_link cht_dailink[] = { ...@@ -445,14 +445,6 @@ static struct snd_soc_dai_link cht_dailink[] = {
.dpcm_playback = 1, .dpcm_playback = 1,
.ops = &cht_aif1_ops, .ops = &cht_aif1_ops,
}, },
[MERR_DPCM_COMPR] = {
.name = "Compressed Port",
.stream_name = "Compress",
.cpu_dai_name = "compress-cpu-dai",
.codec_dai_name = "snd-soc-dummy-dai",
.codec_name = "snd-soc-dummy",
.platform_name = "sst-mfld-platform",
},
/* CODEC<->CODEC link */ /* CODEC<->CODEC link */
/* back ends */ /* back ends */
{ {
......
...@@ -302,14 +302,6 @@ static struct snd_soc_dai_link cht_dailink[] = { ...@@ -302,14 +302,6 @@ static struct snd_soc_dai_link cht_dailink[] = {
.dpcm_playback = 1, .dpcm_playback = 1,
.ops = &cht_aif1_ops, .ops = &cht_aif1_ops,
}, },
[MERR_DPCM_COMPR] = {
.name = "Compressed Port",
.stream_name = "Compress",
.cpu_dai_name = "compress-cpu-dai",
.codec_dai_name = "snd-soc-dummy-dai",
.codec_name = "snd-soc-dummy",
.platform_name = "sst-mfld-platform",
},
/* Back End DAI links */ /* Back End DAI links */
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment