Commit 2196dfea authored by Sudeep Holla's avatar Sudeep Holla Committed by Chris Wilson

drm/i915/selftests: Fix compare functions provided for sorting

Both cmp_u32 and cmp_u64 are comparing the pointers instead of the value
at those pointers. This will result in incorrect/unsorted list. Fix it
by deferencing the pointers before comparison.

Fixes: 4ba74e53 ("drm/i915/selftests: Verify frequency scaling with RPS")
Fixes: 8757797f ("drm/i915/selftests: Repeat the rps clock frequency measurement")
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20200709154931.23310-1-sudeep.holla@arm.com
parent 3d702d06
...@@ -29,9 +29,9 @@ static int cmp_u64(const void *A, const void *B) ...@@ -29,9 +29,9 @@ static int cmp_u64(const void *A, const void *B)
{ {
const u64 *a = A, *b = B; const u64 *a = A, *b = B;
if (a < b) if (*a < *b)
return -1; return -1;
else if (a > b) else if (*a > *b)
return 1; return 1;
else else
return 0; return 0;
...@@ -41,9 +41,9 @@ static int cmp_u32(const void *A, const void *B) ...@@ -41,9 +41,9 @@ static int cmp_u32(const void *A, const void *B)
{ {
const u32 *a = A, *b = B; const u32 *a = A, *b = B;
if (a < b) if (*a < *b)
return -1; return -1;
else if (a > b) else if (*a > *b)
return 1; return 1;
else else
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment