Commit 21f5eda9 authored by Halil Pasic's avatar Halil Pasic Committed by Michael S. Tsirkin

tools/virtio/ringtest: fix run-on-all.sh for offline cpus

Since ef1b144d ("tools/virtio/ringtest: fix run-on-all.sh to work
without /dev/cpu") run-on-all.sh uses seq 0 $HOST_AFFINITY as the list
of ids of the CPUs to run the command on (assuming ids of online CPUs
are consecutive and start from 0), where $HOST_AFFINITY is the highest
CPU id in the system previously determined using lscpu.  This can fail
on systems with offline CPUs.

Instead let's use lscpu to determine the list of online CPUs.
Signed-off-by: default avatarHalil Pasic <pasic@linux.vnet.ibm.com>
Fixes: ef1b144d ("tools/virtio/ringtest: fix run-on-all.sh to work without
/dev/cpu")
Reviewed-by: default avatarSascha Silbe <silbe@linux.vnet.ibm.com>
Signed-off-by: default avatarCornelia Huck <cornelia.huck@de.ibm.com>
parent 8379cadf
#!/bin/sh #!/bin/sh
CPUS_ONLINE=$(lscpu --online -p=cpu|grep -v -e '#')
#use last CPU for host. Why not the first? #use last CPU for host. Why not the first?
#many devices tend to use cpu0 by default so #many devices tend to use cpu0 by default so
#it tends to be busier #it tends to be busier
HOST_AFFINITY=$(lscpu -p=cpu | tail -1) HOST_AFFINITY=$(echo "${CPUS_ONLINE}"|tail -n 1)
#run command on all cpus #run command on all cpus
for cpu in $(seq 0 $HOST_AFFINITY) for cpu in $CPUS_ONLINE
do do
#Don't run guest and host on same CPU #Don't run guest and host on same CPU
#It actually works ok if using signalling #It actually works ok if using signalling
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment