Commit 21f72c9f authored by Jeff Layton's avatar Jeff Layton Committed by J. Bruce Fields

nfsd: fix NULL pointer dereference in cld_pipe_downcall

If we find that "cup" is NULL in this case, then we obviously don't
want to dereference it. What we really want to print in this case
is the xid that we copied off earlier.
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent 3af70613
...@@ -602,8 +602,7 @@ cld_pipe_downcall(struct file *filp, const char __user *src, size_t mlen) ...@@ -602,8 +602,7 @@ cld_pipe_downcall(struct file *filp, const char __user *src, size_t mlen)
/* couldn't find upcall? */ /* couldn't find upcall? */
if (!cup) { if (!cup) {
dprintk("%s: couldn't find upcall -- xid=%u\n", __func__, dprintk("%s: couldn't find upcall -- xid=%u\n", __func__, xid);
cup->cu_msg.cm_xid);
return -EINVAL; return -EINVAL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment