Commit 238f43a7 authored by Bhumika Goyal's avatar Bhumika Goyal Committed by Doug Ledford

IB/qib: add const to bin_attribute structures

Add const to bin_attribute structures as they are only passed to the
functions sysfs_{remove/create}_bin_file. The arguments passed are of
type const, so declare the structures to be const.

Done using Coccinelle.

@M disable optional_qualifier@
identifier s;
position p;
@@
static struct bin_attribute s@p={...};

@okay1@
position p;
identifier m.s;
@@
(
sysfs_create_bin_file(...,&s@p,...)
|
sysfs_remove_bin_file(...,&s@p,...)
)

@bad@
position p!={m.p,okay1.p};
identifier m.s;
@@
s@p

@change depends on !bad disable optional_qualifier@
identifier m.s;
@@
static
+const
struct bin_attribute s={...};
Signed-off-by: default avatarBhumika Goyal <bhumirks@gmail.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 699a2d5b
...@@ -247,7 +247,7 @@ static struct kobj_type qib_port_cc_ktype = { ...@@ -247,7 +247,7 @@ static struct kobj_type qib_port_cc_ktype = {
.release = qib_port_release, .release = qib_port_release,
}; };
static struct bin_attribute cc_table_bin_attr = { static const struct bin_attribute cc_table_bin_attr = {
.attr = {.name = "cc_table_bin", .mode = 0444}, .attr = {.name = "cc_table_bin", .mode = 0444},
.read = read_cc_table_bin, .read = read_cc_table_bin,
.size = PAGE_SIZE, .size = PAGE_SIZE,
...@@ -286,7 +286,7 @@ static ssize_t read_cc_setting_bin(struct file *filp, struct kobject *kobj, ...@@ -286,7 +286,7 @@ static ssize_t read_cc_setting_bin(struct file *filp, struct kobject *kobj,
return count; return count;
} }
static struct bin_attribute cc_setting_bin_attr = { static const struct bin_attribute cc_setting_bin_attr = {
.attr = {.name = "cc_settings_bin", .mode = 0444}, .attr = {.name = "cc_settings_bin", .mode = 0444},
.read = read_cc_setting_bin, .read = read_cc_setting_bin,
.size = PAGE_SIZE, .size = PAGE_SIZE,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment