Commit 24190364 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

dsp56k: prevent a harmless underflow

There is a mistake here where we don't allow "len" to be zero but we
allow negative lengths.  It's basically harmless in this case, but the
underflow makes my static checker complain.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 077e2642
...@@ -325,7 +325,7 @@ static long dsp56k_ioctl(struct file *file, unsigned int cmd, ...@@ -325,7 +325,7 @@ static long dsp56k_ioctl(struct file *file, unsigned int cmd,
if(get_user(bin, &binary->bin) < 0) if(get_user(bin, &binary->bin) < 0)
return -EFAULT; return -EFAULT;
if (len == 0) { if (len <= 0) {
return -EINVAL; /* nothing to upload?!? */ return -EINVAL; /* nothing to upload?!? */
} }
if (len > DSP56K_MAX_BINARY_LENGTH) { if (len > DSP56K_MAX_BINARY_LENGTH) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment