Commit 24bf86cc authored by Hans de Goede's avatar Hans de Goede

drm/i915/dsi: Enable dithering for 6 bpc panels

The display engine has 2 dithering enable bits which both need to be set
for dithering to happen, 1 in the PIPECONF register which is taken care of
by i9xx_set_pipeconf() and a second bit at the encoder level.

The dsi code was not setting the encoder level dithering enable bit causing
dithering to be disabled, this commit fixes this.
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Reviewed-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181201113148.23184-2-hdegoede@redhat.com
parent ca0b04db
...@@ -678,6 +678,10 @@ static void intel_dsi_port_enable(struct intel_encoder *encoder, ...@@ -678,6 +678,10 @@ static void intel_dsi_port_enable(struct intel_encoder *encoder,
LANE_CONFIGURATION_DUAL_LINK_B : LANE_CONFIGURATION_DUAL_LINK_B :
LANE_CONFIGURATION_DUAL_LINK_A; LANE_CONFIGURATION_DUAL_LINK_A;
} }
if (intel_dsi->pixel_format != MIPI_DSI_FMT_RGB888)
temp |= DITHERING_ENABLE;
/* assert ip_tg_enable signal */ /* assert ip_tg_enable signal */
I915_WRITE(port_ctrl, temp | DPI_ENABLE); I915_WRITE(port_ctrl, temp | DPI_ENABLE);
POSTING_READ(port_ctrl); POSTING_READ(port_ctrl);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment