Commit 258f79d5 authored by Heinrich Schuchardt's avatar Heinrich Schuchardt Committed by Linus Torvalds

scripts/checkpatch.pl: avoid false warning missing break

void foo(int a)
	switch (a) {
	case 'h':
		fun1();
		exit(1);
	default:
}

creates a warning "Possible switch case/default not preceded by break or
fallthrough comment".

exit( should be treated like return.

Link: http://lkml.kernel.org/r/20170910154618.25819-1-xypron.glpk@gmx.deSigned-off-by: default avatarHeinrich Schuchardt <xypron.glpk@gmx.de>
Acked-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 25bdda2b
...@@ -6109,7 +6109,7 @@ sub process { ...@@ -6109,7 +6109,7 @@ sub process {
next if ($fline =~ /^.[\s$;]*$/); next if ($fline =~ /^.[\s$;]*$/);
$has_statement = 1; $has_statement = 1;
$count++; $count++;
$has_break = 1 if ($fline =~ /\bswitch\b|\b(?:break\s*;[\s$;]*$|return\b|goto\b|continue\b)/); $has_break = 1 if ($fline =~ /\bswitch\b|\b(?:break\s*;[\s$;]*$|exit\s*\(\b|return\b|goto\b|continue\b)/);
} }
if (!$has_break && $has_statement) { if (!$has_break && $has_statement) {
WARN("MISSING_BREAK", WARN("MISSING_BREAK",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment