Commit 259692bd authored by Jesper Juhl's avatar Jesper Juhl Committed by Dave Kleikamp

JFS: Remove redundant kfree() NULL pointer checks

kfree() can handle a NULL pointer, don't worry about passing it one. 
Signed-off-by: default avatarJesper Juhl <juhl-lkml@dif.dk>
Signed-off-by: default avatarDave Kleikamp <shaggy@austin.ibm.com>
parent 6f817abc
...@@ -70,8 +70,7 @@ static struct posix_acl *jfs_get_acl(struct inode *inode, int type) ...@@ -70,8 +70,7 @@ static struct posix_acl *jfs_get_acl(struct inode *inode, int type)
if (!IS_ERR(acl)) if (!IS_ERR(acl))
*p_acl = posix_acl_dup(acl); *p_acl = posix_acl_dup(acl);
} }
if (value) kfree(value);
kfree(value);
return acl; return acl;
} }
...@@ -112,8 +111,7 @@ static int jfs_set_acl(struct inode *inode, int type, struct posix_acl *acl) ...@@ -112,8 +111,7 @@ static int jfs_set_acl(struct inode *inode, int type, struct posix_acl *acl)
} }
rc = __jfs_setxattr(inode, ea_name, value, size, 0); rc = __jfs_setxattr(inode, ea_name, value, size, 0);
out: out:
if (value) kfree(value);
kfree(value);
if (!rc) { if (!rc) {
if (*p_acl && (*p_acl != JFS_ACL_NOT_CACHED)) if (*p_acl && (*p_acl != JFS_ACL_NOT_CACHED))
......
...@@ -946,8 +946,7 @@ int __jfs_setxattr(struct inode *inode, const char *name, const void *value, ...@@ -946,8 +946,7 @@ int __jfs_setxattr(struct inode *inode, const char *name, const void *value,
out: out:
up_write(&JFS_IP(inode)->xattr_sem); up_write(&JFS_IP(inode)->xattr_sem);
if (os2name) kfree(os2name);
kfree(os2name);
return rc; return rc;
} }
...@@ -1042,8 +1041,7 @@ ssize_t __jfs_getxattr(struct inode *inode, const char *name, void *data, ...@@ -1042,8 +1041,7 @@ ssize_t __jfs_getxattr(struct inode *inode, const char *name, void *data,
out: out:
up_read(&JFS_IP(inode)->xattr_sem); up_read(&JFS_IP(inode)->xattr_sem);
if (os2name) kfree(os2name);
kfree(os2name);
return size; return size;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment